crashpad: update mini_chromium-win_helper patch #27077
Open
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Changes to recipe: crashpad/cci.20220219
Motivation
Integrating the improvement from chromium/mini_chromium@aa56c39 into the mini_chromium win_helper.py patch to fix Windows build failures.
Details
(Copy-paste from chromium/mini_chromium@aa56c39):
On a system with only the Visual Studio Build Tools workload installed
(version 2022/17.13.0), but not Enterprise, Professional, or Community,
vswhere -latest -property installationPathwas not returning anything,resulting in this script failing with “Exception: Visual Studio
installation dir not found” during
gn gen.Evidently, vswhere by default only looks for
Microsoft.VisualStudio.Product.{Enterprise,Professional,Community}, but
not BuildTools. BuildTools alone (with a suitable SDK) should be
sufficient for Crashpad development. Specifying
-products *shouldallow vswhere to find the products it was previously able to locate, and
also Microsoft.VisualStudio.Product.BuildTools.