json.cpp: add recipe #26733
Open
json.cpp: add recipe #26733
+207
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AbrilRBS
reviewed
Apr 23, 2025
| #include <cstdint> | ||
| #include <cstdlib> | ||
| - | ||
| +#include <cstdbool> |
There was a problem hiding this comment.
This is for newer gcc I assume? It would be great to report this upstream
There was a problem hiding this comment.
@AbrilRBS
Sorry.
I confirmed this patch is not needed.
Fixed.
There was a problem hiding this comment.
A bit unfortunate that this file requires this many changes, but looks ok
- Unvendorizes double-conversion & dependencies
- Removes tests
- Add INSTALL instructions 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Changes to recipe: json.cpp/*
Motivation
json.cpp is over 700 stars repository.
Details
https://github.com/jart/json.cpp