-
Notifications
You must be signed in to change notification settings - Fork 2k
stacktrace: add version 1.0.0 #26599
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
@jcar87 I feel like I'm missing something here. Thanks in advance and have a nice weekend! |
Hi @AiyionPrime - apologies we didn't get to you in time. We review PRs before running on our CI for first time contributors (or past contributors after long inactivity) - when we don't, we should leave a message about this, apologies that this didn't happen in time. It is a bit unusual for us to add libraries where the code doesn't come from a canonical location that the recipe references for download. Including external code can tangle the licensing of the repository (we are not the authors), and confuse the maintenance story: we don't maintain the libraries, we maintain the recipes. We typically look at this being hosted and maintained - and look for evidence of usage elsewhere (e.g. stars on github, availability on other linux distros, etc). Do you know if the latter is the case, to make a compelling case? Either way - we would require the sources to be available externally in a canonical location. |
@jcar87 Thanks for the fast response! No worries, I just felt like waiting longer would not have benefited the cause anymore. To answer in reverse order: There is little to no maintenance expected for this header, https://panthema.net/2008/0901-stacktrace-demangled/stacktrace.h |
dde6144
to
9906aae
Compare
@jcar87 Alright, I found the I cleaned up the conanfile, rebased this onto master and hope this is now fit for a first inspection. Have a nice weekend everyone! |
Co-authored-by: Timo Bingmann <[email protected]>
9906aae
to
f406677
Compare
This comment was marked as outdated.
This comment was marked as outdated.
@jcar87 Thanks :) |
Summary
Implementation of recipe: stacktrace/[1.0.0]
fixes #26601
Motivation
I'd like to get rid of a submodule in our project.
For most of my dependencies there existed conan2 packages, this one is lacking.
The header is small, not expected to change anymore and not present in git or zip-form.
Details
In 2008 Timo Bingmann wrote a useful helper to demangle gcc/clang compilations and did a writeup: https://panthema.net/2008/0901-stacktrace-demangled/
I really appreciate the size/usefulness ratio and would like to see it in the CCI.
There is currently no CCI issue this PR fixes, as I did read the guide after implementing the recipe. I can open an issue if desired, just feel like we can discuss the contribution here as well.Created #26601 to fulfill the git flow.I'm a first time contributor, and though I read the guidelines and the packaging tutorial increased attention to detail while reviewing might be in order :)