Skip to content

stacktrace: add version 1.0.0 #26599

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

AiyionPrime
Copy link

@AiyionPrime AiyionPrime commented Feb 14, 2025

Summary

Implementation of recipe: stacktrace/[1.0.0]
fixes #26601

Motivation

I'd like to get rid of a submodule in our project.
For most of my dependencies there existed conan2 packages, this one is lacking.

The header is small, not expected to change anymore and not present in git or zip-form.

Details

In 2008 Timo Bingmann wrote a useful helper to demangle gcc/clang compilations and did a writeup: https://panthema.net/2008/0901-stacktrace-demangled/

I really appreciate the size/usefulness ratio and would like to see it in the CCI.

There is currently no CCI issue this PR fixes, as I did read the guide after implementing the recipe. I can open an issue if desired, just feel like we can discuss the contribution here as well. Created #26601 to fulfill the git flow.

I'm a first time contributor, and though I read the guidelines and the packaging tutorial increased attention to detail while reviewing might be in order :)


@AiyionPrime AiyionPrime marked this pull request as ready for review February 14, 2025 17:19
@AiyionPrime AiyionPrime mentioned this pull request Feb 19, 2025
3 tasks
@AiyionPrime
Copy link
Author

@jcar87 I feel like I'm missing something here.
Could you tell me how I'd get the Job scheduler to at least validate the PR?

Thanks in advance and have a nice weekend!

@jcar87
Copy link
Contributor

jcar87 commented Mar 7, 2025

Hi @AiyionPrime - apologies we didn't get to you in time. We review PRs before running on our CI for first time contributors (or past contributors after long inactivity) - when we don't, we should leave a message about this, apologies that this didn't happen in time.

It is a bit unusual for us to add libraries where the code doesn't come from a canonical location that the recipe references for download. Including external code can tangle the licensing of the repository (we are not the authors), and confuse the maintenance story: we don't maintain the libraries, we maintain the recipes. We typically look at this being hosted and maintained - and look for evidence of usage elsewhere (e.g. stars on github, availability on other linux distros, etc). Do you know if the latter is the case, to make a compelling case? Either way - we would require the sources to be available externally in a canonical location.

@AiyionPrime
Copy link
Author

AiyionPrime commented Mar 7, 2025

@jcar87 Thanks for the fast response! No worries, I just felt like waiting longer would not have benefited the cause anymore.

To answer in reverse order:
The code is used quite frequently, but always as hard copy due to its lack of a repo.
On GitHub I find about 80+ usages of this, and that's without reformatted variants.
https://github.com/search?q=%22static+inline+void+print_stacktrace%28FILE+*out+%3D+stderr%2C+unsigned+int+max_frames+%3D+63%29%22&type=code&p=1

There is little to no maintenance expected for this header,
so would it be fine to use the authors hosted code, which is not a git repo for now?

https://panthema.net/2008/0901-stacktrace-demangled/stacktrace.h

@AiyionPrime AiyionPrime force-pushed the stacktrace/add-1_0_0 branch from dde6144 to 9906aae Compare March 7, 2025 16:20
@AiyionPrime
Copy link
Author

@jcar87 Alright, I found the download tool which appears to be the right choice for the job.
I do understand a git repo would be nicer, but given the lack of changes in the past and the fixed sha256sum, I'd say this suffices for now.

I cleaned up the conanfile, rebased this onto master and hope this is now fit for a first inspection. Have a nice weekend everyone!

Co-authored-by: Timo Bingmann <[email protected]>
@AiyionPrime AiyionPrime force-pushed the stacktrace/add-1_0_0 branch from 9906aae to f406677 Compare March 17, 2025 11:41
@AiyionPrime

This comment was marked as outdated.

@AiyionPrime
Copy link
Author

@jcar87 Thanks :)
Anything is there anything left to do here for me?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[request] stacktrace/1.0.0
2 participants