ffmpeg: add option to use the opencore amr nb/wb decoder instead of built-in amr decoder #26217
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Changes to recipe: ffmpeg
Motivation
This pull request allows users to enable the opencore amr decoder in ffmpeg. The internal amr wideband/narrowband decoder lacks some features and suggests to use opencore-amr (see here: https://github.com/FFmpeg/FFmpeg/blob/8272d34377b24e52de0492fbc2e1d74efcdff248/libavcodec/amrnbdec.c#L989C47-L989C64 ).
Details
with_opencore_amr
opencore-amr
package--enable-version3
flag to upgrade to (L)GPL version 3with_lgpl_version_3
with_lgpl_version_3
option is the best way to model this flag. A alternative could be to add the--enable-version3
flag if opencore-amr is enabled