Skip to content

ffmpeg: add option to use the opencore amr nb/wb decoder instead of built-in amr decoder #26217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

hwse
Copy link

@hwse hwse commented Dec 18, 2024

Summary

Changes to recipe: ffmpeg

Motivation

This pull request allows users to enable the opencore amr decoder in ffmpeg. The internal amr wideband/narrowband decoder lacks some features and suggests to use opencore-amr (see here: https://github.com/FFmpeg/FFmpeg/blob/8272d34377b24e52de0492fbc2e1d74efcdff248/libavcodec/amrnbdec.c#L989C47-L989C64 ).

Details

  • I added a option to enable opencore amr: with_opencore_amr
    • default is off
    • if enabled it adds a dependency to the opencore-amr package
    • also the internal amr decoder is disabled with this option
  • when using opencore-amr we need to pass the --enable-version3 flag to upgrade to (L)GPL version 3

@CLAassistant
Copy link

CLAassistant commented Dec 18, 2024

CLA assistant check
All committers have signed the CLA.

@hwse
Copy link
Author

hwse commented Jan 6, 2025

Related Issue: #26308

Copy link

@KepptnKool KepptnKool left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good

Copy link

@thedavidhk thedavidhk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants