simple_enum: add new version 0.8.11 #26028
Open
+14
−24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AbrilRBS
reviewed
Nov 25, 2024
This was referenced Nov 25, 2024
toge
changed the title
toge
changed the title
toge
changed the title
toge
changed the title
AbrilRBS
approved these changes
Jun 17, 2025
There was a problem hiding this comment.
As discussed in #26028 (review), the glaze requirement seems to be required
jcar87
reviewed
Jul 2, 2025
| @@ -72,3 +55,5 @@ def package(self): | |||
| def package_info(self): | |||
| self.cpp_info.bindirs = [] | |||
| self.cpp_info.libdirs = [] | |||
|
|
|||
| self.cpp_info.defines.append("SIMPLE_ENUM_GLZ_3_1_x") | |||
There was a problem hiding this comment.
I may be missing something here, where does this come from?
I can't find references in https://github.dev/arturbac/simple_enum/tree/v0.8.11
|
|
||
| def layout(self): | ||
| basic_layout(self, src_folder="src") | ||
|
|
||
| def requirements(self): | ||
| self.requires("glaze/4.0.1") |
There was a problem hiding this comment.
the public headers of simple_enum dont make any references to glaze whatsoever - in the codebase it seems like its used only in examples and tests, but not the actual header library. it's documented as being opt-in by the end user, to include both, so I'm not sure if this is required here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Changes to recipe: simple_enum/0.8.11
Motivation
There are several improvements since 0.8.0.
Details
arturbac/simple_enum@v0.8.0...v0.8.11