Skip to content

mpdecimal: Misc cleanup #25918

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 39 commits into
base: master
Choose a base branch
from

Conversation

Ahajha
Copy link
Contributor

@Ahajha Ahajha commented Nov 11, 2024

Primary changes, roughly in order of LOC changed:

  • Remove the 'configure' patches, these no longer have any effect since that script isn't run anymore.
  • Remove the v1 test package
  • Remove the legacy CONAN_***FLAGS being patched in
  • Simplify the 'package' step (mainly unifying all the different cases)
  • Simplify the 'build' step (mainly remove the exact target name calculation and letting the build system handle it)
  • Simplify the 'generate' step (mainly remove redundant or unnecessary generators)
  • Remove usage of the deprecated 'path' variables
  • Add in patch descriptions
  • Make patch file naming more consistent

There are some very minor functional differences:

  • Fixed the license file not being packaged in 4.0.0, LICENSE.txt was changed to COPYRIGHT.txt
  • The LIBMPDECXX_DLL define has been unified with LIBMPDEC_DLL - I see no reason to distinguish these two as they are either both shared or both static.

Related: 2.4.2 is being removed in #26092

@Ahajha Ahajha force-pushed the ahajha/mpdecimal-cleanup branch 2 times, most recently from 0d85f42 to 3176e23 Compare November 15, 2024 17:10
@Ahajha
Copy link
Contributor Author

Ahajha commented Nov 15, 2024

@jcar87 This is still a draft, but the "Validate PR" job has been failing since the "Merge 2.4.2 into 2.5.x folder" commit. Does the new CI not like modifying multiple folders under the same recipe?

@Ahajha Ahajha marked this pull request as ready for review December 4, 2024 03:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants