-
Notifications
You must be signed in to change notification settings - Fork 2k
libpq: update mingw static libraries patch to work with 15.4 #25453
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
libpq: update mingw static libraries patch to work with 15.4 #25453
Conversation
…rk with 15.4 Building libpq/15.4 static on MinGW produces an empty libpq.a librariy. When used, linking fails with undefined references. The updated patches/15/001-mingw-build-static-libraries.patch fixes that.
This comment has been minimized.
This comment has been minimized.
Conan v1 pipeline ✔️Warning Conan Center will stop receiving updates for Conan 1.x packages soon - please see announcement. All green in build 2 (
Conan v2 pipeline ✔️
All green in build 2 (
|
So sorry for the noise here |
Hello @scandyna, I'm sorry for not getting back to you sooner. I was looking at this new patch. I’ve tried to connect it with some upstream issue or thread discussing the matter, but I haven’t found anything. Could you help me understand the origin of these changes? I appreciate any help you can provide. |
Summary
Changes to recipe: libpq/15 (not the recipe, but a patch)
Motivation
See #25282
Building libpq/15.4 static on MinGW produces an empty
libpq.a
library. When used, linking fails with undefined references.Details
The
patches/15/001-mingw-build-static-libraries.patch
was created to fix MinGW static builds and worked for erlier versions of libpq, but fails for 15.4.Digging in what this patch does, I found a missing block that also has to be patched in the
Makefile.shlib
, starting at line 358:With this PR, this block will be replaced with:
I ran the tests for some configurations:
https://gitlab.com/scandyna/conan-center-index-partialbasicci-sandbox/-/pipelines/1474053728
Note that for MSVC, the
test_v1_package
fails. Probably something missing in my environment (I don't use thecmake
generator anymore).