add package qtils 0.0.4 #25121
add package qtils 0.0.4 #25121
Conversation
|
|
This comment has been minimized.
This comment has been minimized.
|
Where can I check for assembly line errors? |
When this PR runs once the approval process goes thru, you'll get the compilation logs summarized here :) |
There was a problem hiding this comment.
Hi! Thanks for taking the time to add this new recipe.
There are some changes that will need to be made (You can base your recipe in the header_only package template in https://github.com/conan-io/conan-center-index/tree/master/docs/package_templates/header_only to get most of this already done for you!), but this first take looks good most of the way! Thanks :)
recipes/qtils/all/conanfile.py
Outdated
|
|
||
| class PackageConan(ConanFile): | ||
| name = "qtils" | ||
| version = "0.0.4" |
There was a problem hiding this comment.
| version = "0.0.4" |
This gets automatically set by the CI based on the conandata contents
recipes/qtils/all/conanfile.py
Outdated
|
|
||
| def package(self): | ||
| include_folder = os.path.join(self.source_folder, "src") | ||
| copy(self, "*.hpp", dst=os.path.join(self.package_folder, "include"), src=include_folder, keep_path=True) |
There was a problem hiding this comment.
We'll need to package the LICENSE file from upstream here too, check how this is done in the header_only package template in https://github.com/conan-io/conan-center-index/tree/master/docs/package_templates/header_only
recipes/qtils/all/conanfile.py
Outdated
| def generate(self): | ||
| tc = CMakeToolchain(self) | ||
| tc.generate() | ||
| deps = CMakeDeps(self) | ||
| deps.generate() |
There was a problem hiding this comment.
No need for any if this as we're not building
recipes/qtils/all/conanfile.py
Outdated
| from conan.tools.cmake import CMakeToolchain, CMakeDeps, cmake_layout | ||
| from conan.tools.files import copy,get | ||
|
|
||
| required_conan_version = ">=2.0.5" |
There was a problem hiding this comment.
We still need to support Conan 1 for now.
| required_conan_version = ">=2.0.5" | |
| required_conan_version = ">=1.53.0" |
recipes/qtils/all/conanfile.py
Outdated
| settings = "os", "compiler", "build_type", "arch" | ||
|
|
||
| def layout(self): | ||
| cmake_layout(self) |
There was a problem hiding this comment.
This shuold probably be a basic_layout if we're not doing anything special
recipes/qtils/all/conanfile.py
Outdated
|
|
||
| def build(self): | ||
| # Only header files, no source files that need to be compiled, so skip the build step | ||
| pass |
There was a problem hiding this comment.
Missing a package_id() that calls self.info.clear() as is usually done for header-only libraries
|
Also, the library seems to need set |
|
@AbrilRBS |
Conan v1 pipeline ✔️All green in build 3 (
Conan v2 pipeline ✔️
All green in build 3 (
|
Summary
Changes to recipe: qtils/0.0.4
Motivation
add a new package by cpp-libp2p