-
Notifications
You must be signed in to change notification settings - Fork 2k
Add options for Emscripten platform #24961
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
This comment has been minimized.
This comment has been minimized.
Conan v1 pipeline ✔️All green in build 2 (
Conan v2 pipeline ❌
The v2 pipeline failed. Please, review the errors and note this is required for pull requests to be merged. In case this recipe is still not ported to Conan 2.x, please, ping Sorry, the build is only launched for Access Request users. You can request access writing in this issue. |
Hooks produced the following warnings for commit c891068opencv/4.1.2@#da6af861294ed4cf10631e1545a9063a
opencv/4.8.1@#7186ebcbe6d9da01a5e95b450385951e
opencv/4.5.3@#9b76faaee22d86cf833fdbc7fe6a792f
opencv/4.10.0@#e81f921c9caede9a82877132067dcfb8
opencv/4.5.5@#bc98380c6efcdb133cf88d81d216f684
opencv/4.9.0@#839c06a2943c3814c0a990da5c364bdc
|
Hi @mattangus, I've just merged this branch with master, is there any progress on this PR? |
I was hoping to get some feedback on the proper way to set these options. It doesn't leave much room for customization. Is there a way to specify the default options for conan-center-index/recipes/opencv/4.x/conanfile.py Lines 370 to 403 in 9834a71
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Summary
Changes to recipe: opencv/4.x
Automatically detects when the user is compiling for
emscripten
.Motivation
Related to #13171. The use can set these options themselves. But with the default options when compiling with
emsdk
, the compilation will fail.Details
This sets the options found in
platforms/js/build_js.py
. I didn't want to add more options, so it assumes that the user would have passed the--build_wasm
and--simd
flag to that script.