-
Notifications
You must be signed in to change notification settings - Fork 2k
[outcome] Add option single_header #24727
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
[outcome] Add option single_header #24727
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Waiting for this PR to be merged: #24728 |
This comment has been minimized.
This comment has been minimized.
Conan v1 pipeline ✔️All green in build 4 (
Conan v2 pipeline ✔️
All green in build 4 ( |
@jeremy-coulon Hello! Thank you for your PR, and sorry for the delay in reviewing it. Some comments about your PR: The upstream indeed documents about using single-header or multiple headers for Outcome: When consuming external status-code from a package manager, a definition should be exported as well: https://github.com/ned14/outcome/blob/develop/CMakeLists.txt#L172C34-L172C64. It should be added to The non-packaged project llfio is consuming outcome as pointed: https://github.com/ned14/llfio/blob/06ea607de0346a1d77a807fd37efc2fdfb005de5/programs/CMakeLists.txt#L15C26-L15C33 And requires non single-header variant: https://github.com/ned14/llfio/blob/06ea607de0346a1d77a807fd37efc2fdfb005de5/include/llfio/v2.0/multiplex.hpp#L30 This PR makes sense in terms of supporting llfio, but it will not work when adding llfio in ConanCenterIndex, because the package Outcome with the single_header=False will not exist in Conan Center, resulting in the missing headers. |
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Summary
Changes to recipe: outcome/*
Motivation
Add
single_header
option. Default isTrue
for backward compatibility.Details
I need
single_header=False
for my own recipe of LLFIOI found a duplicate PR which is closed here #15995
My solution seems much simpler.