Skip to content

[outcome] Add option single_header #24727

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

jeremy-coulon
Copy link
Contributor

Summary

Changes to recipe: outcome/*

Motivation

Add single_header option. Default is True for backward compatibility.

Details

I need single_header=False for my own recipe of LLFIO
I found a duplicate PR which is closed here #15995
My solution seems much simpler.


@conan-center-bot

This comment has been minimized.

@jeremy-coulon jeremy-coulon marked this pull request as draft July 26, 2024 14:37
@conan-center-bot

This comment has been minimized.

@jeremy-coulon
Copy link
Contributor Author

outcome also depends on a recent version of status-code when single_header=False

Waiting for this PR to be merged: #24728

@conan-center-bot

This comment has been minimized.

@jeremy-coulon jeremy-coulon marked this pull request as ready for review August 2, 2024 10:56
@conan-center-bot
Copy link
Contributor

Conan v1 pipeline ✔️

All green in build 4 (641357f16dcea7b71c05551065879276ee209a1a):

  • outcome/2.2.8:
    All packages built successfully! (All logs)

  • outcome/2.2.9:
    All packages built successfully! (All logs)

  • outcome/2.2.7:
    All packages built successfully! (All logs)

  • outcome/2.2.4:
    All packages built successfully! (All logs)

  • outcome/2.1.5:
    All packages built successfully! (All logs)


Conan v2 pipeline ✔️

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

All green in build 4 (641357f16dcea7b71c05551065879276ee209a1a):

  • outcome/2.2.8:
    All packages built successfully! (All logs)

  • outcome/2.2.9:
    All packages built successfully! (All logs)

  • outcome/2.2.7:
    All packages built successfully! (All logs)

  • outcome/2.2.4:
    All packages built successfully! (All logs)

  • outcome/2.1.5:
    All packages built successfully! (All logs)

@AbrilRBS AbrilRBS self-assigned this Aug 5, 2024
@uilianries
Copy link
Member

@jeremy-coulon Hello! Thank you for your PR, and sorry for the delay in reviewing it.

Some comments about your PR:

The upstream indeed documents about using single-header or multiple headers for Outcome:
https://github.com/ned14/outcome#usage-as-a-single-header-file

When consuming external status-code from a package manager, a definition should be exported as well: https://github.com/ned14/outcome/blob/develop/CMakeLists.txt#L172C34-L172C64. It should be added to package_info.

The non-packaged project llfio is consuming outcome as pointed: https://github.com/ned14/llfio/blob/06ea607de0346a1d77a807fd37efc2fdfb005de5/programs/CMakeLists.txt#L15C26-L15C33 And requires non single-header variant: https://github.com/ned14/llfio/blob/06ea607de0346a1d77a807fd37efc2fdfb005de5/include/llfio/v2.0/multiplex.hpp#L30

This PR makes sense in terms of supporting llfio, but it will not work when adding llfio in ConanCenterIndex, because the package Outcome with the single_header=False will not exist in Conan Center, resulting in the missing headers.

Copy link
Contributor

github-actions bot commented Jul 7, 2025

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale label Jul 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants