Skip to content

libssh2: do not rely on _WINDLL or DLL_EXPORT defines #23683

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

valgur
Copy link

@valgur valgur commented Apr 20, 2024

Static libssh2 Windows packages are prone to failing in consuming packages due to libssh2 relying on unnamespaced _WINDLL and DLL_EXPORT shared/static defines.

Should fix the unresolved external symbol __imp_libssh2_init errors in test_package for #18810.

Similar to #23680.

@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

All green in build 1 (3d447aea8933491d61e91b9ed0e49d2767dd974a):

  • libssh2/1.9.0:
    All packages built successfully! (All logs)

  • libssh2/1.8.2:
    All packages built successfully! (All logs)

  • libssh2/1.11.0:
    All packages built successfully! (All logs)

  • libssh2/1.10.0:
    All packages built successfully! (All logs)


Conan v2 pipeline ✔️

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

All green in build 1 (3d447aea8933491d61e91b9ed0e49d2767dd974a):

  • libssh2/1.8.2:
    All packages built successfully! (All logs)

  • libssh2/1.11.0:
    All packages built successfully! (All logs)

  • libssh2/1.10.0:
    All packages built successfully! (All logs)

  • libssh2/1.9.0:
    All packages built successfully! (All logs)

danimtb
danimtb previously approved these changes Jul 4, 2024
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Martin Valgur seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@conan-center-build-service conan-center-build-service bot locked as off-topic and limited conversation to collaborators Mar 17, 2025
@valgur valgur deleted the bugfix/libssh2 branch April 10, 2025 12:11
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants