-
Notifications
You must be signed in to change notification settings - Fork 2k
cyrus-sasl: patch packaged headers to work with msvc compiler #23602
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Conan v1 pipeline ✔️All green in build 2 (
Conan v2 pipeline ✔️
All green in build 2 ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot! We really appreciate you opening the issue upstream and linking back there in the code <3
My understanding is that upstream will fix this similarly to how you've implemented here, but let's give them a few days just in case they supprise us, else I'll aprove by monday :)
…adamws-cyrus-sasl-msvc-test-23602-cii-command
Signed-off-by: Uilian Ries <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@adamws Thank you for your PR!
I made a change in your PR, I replaced your patch by the official one from the upstream.
Still, I can confirm your bug, without that patch, my build on Windows fails: cyrus-sasl-2.1.28-no-patch.log
Then, after applying the patch, it works without any error: cyrus-sasl-2.1.28-patched.log
Regards!
@uilianries thanks for updating, looks good to me. |
Specify library name and version: cyrus-sasl/2.1.28
When using msvc compiler and
saslplug.h
include, it would fail to compile test_package.I addressed that problem here: cyrusimap/cyrus-sasl#831 - until solved upstream I think this qualifies for patching here (which this PR does)