-
Notifications
You must be signed in to change notification settings - Fork 2k
asio-grpc: add version 3.4.1 #22910
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
asio-grpc: add version 3.4.1 #22910
Conversation
This comment has been minimized.
This comment has been minimized.
a7f64cd
to
503edec
Compare
This comment has been minimized.
This comment has been minimized.
@valgur any chance you could get someone else from the team to review this pull request so that it can finally get merged? :) |
This comment has been minimized.
This comment has been minimized.
@valgur sorry to bother you again, but is there any chance some of your teammates have time to review this PR? |
Hi @Tradias first of all, thank you for your contribution! |
This comment has been minimized.
This comment has been minimized.
@perseoGI Thanks for taking the time to review my pull request. Indeed, there is a new version upstream v3.1.0. I created #24470 as well. Possibly to be done after merging this pr or within in. I do not know what works best for you/conan. I am not sure what you mean by |
This comment has been minimized.
This comment has been minimized.
At Conan we tend to be always up2date with latest releases. For that reason, I think it is better to add the latest release in this PR (you can change the title if you wish).
Sorry I did not explain myself correct. I meant to check out any change on CMake files, etc which could affect how conan should export, compile, package, etc your project. If there are no breaking changes, then it is good to go! |
This comment has been minimized.
This comment has been minimized.
@AbrilRBS I forgot that older versions of asio-grpc are not compatible with the latest version of asio. What to do now? |
@Tradias can I suggest that you simply conditionally branch the requirements for the older version in the |
This comment has been minimized.
This comment has been minimized.
@AbrilRBS I addressed the issues that came with the version bump of dependencies. Any more concerns? |
Conan v1 pipeline ✔️All green in build 10 (
Conan v2 pipeline ✔️
All green in build 10 (
|
@jcar87 This pr has been open for quite a while now, any chance to finally get it merged? |
2916665
to
8366494
Compare
Specify library name and version: asio-grpc/3.4.1
Asio-grpc v3.0.0 no longer uses
local_allocator_option
. It could have a newbackend_option
in https://github.com/NVIDIA/stdexec but there does not seem to be a recipe for it here in conan-center.Contains #19070
Note, I am the author of asio-grpc.