Skip to content

asio-grpc: add version 3.4.1 #22910

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Feb 27, 2025
Merged

asio-grpc: add version 3.4.1 #22910

merged 9 commits into from
Feb 27, 2025

Conversation

Tradias
Copy link
Contributor

@Tradias Tradias commented Feb 27, 2024

Specify library name and version: asio-grpc/3.4.1

Asio-grpc v3.0.0 no longer uses local_allocator_option. It could have a new backend_option in https://github.com/NVIDIA/stdexec but there does not seem to be a recipe for it here in conan-center.

Contains #19070

Note, I am the author of asio-grpc.


@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@Tradias
Copy link
Contributor Author

Tradias commented May 8, 2024

@valgur any chance you could get someone else from the team to review this pull request so that it can finally get merged? :)

@Tradias Tradias force-pushed the asio-grpc-3-0-0 branch from 503edec to 2123628 Compare May 23, 2024 08:09
@conan-center-bot

This comment has been minimized.

@c4pQ
Copy link

c4pQ commented May 28, 2024

@valgur sorry to bother you again, but is there any chance some of your teammates have time to review this PR?

@perseoGI perseoGI self-assigned this Jul 8, 2024
@perseoGI
Copy link
Contributor

perseoGI commented Jul 8, 2024

Hi @Tradias first of all, thank you for your contribution!
I see you are the creator of asio-grpc. That is a good information for you to put in the PR description :)
On the other hand, before merging this one, I see you have released a new version.
You may take a look at this diff Tradias/asio-grpc@v2.9.2...v3.1.0 and validate all build tools changes!

@conan-center-bot

This comment has been minimized.

@Tradias
Copy link
Contributor Author

Tradias commented Jul 8, 2024

@perseoGI Thanks for taking the time to review my pull request.

Indeed, there is a new version upstream v3.1.0. I created #24470 as well. Possibly to be done after merging this pr or within in. I do not know what works best for you/conan.

I am not sure what you mean by validate all build tools changes. Compiler support is not expected to change with v3.

@conan-center-bot

This comment has been minimized.

@perseoGI
Copy link
Contributor

perseoGI commented Jul 9, 2024

I created #24470 as well. Possibly to be done after merging this pr or within in. I do not know what works best for you/conan.

At Conan we tend to be always up2date with latest releases. For that reason, I think it is better to add the latest release in this PR (you can change the title if you wish).
If the semantic versioning you are using is strict, we also like sometimes to do some clean ups, meaning removing support for intermediate patch versions and keeping only the latest patch of each minor. This way, conan CI will be much faster! (Previous pre-binaries will be maintained)

I am not sure what you mean by validate all build tools changes. Compiler support is not expected to change with v3.

Sorry I did not explain myself correct. I meant to check out any change on CMake files, etc which could affect how conan should export, compile, package, etc your project. If there are no breaking changes, then it is good to go!

@conan-center-bot

This comment has been minimized.

@Tradias
Copy link
Contributor Author

Tradias commented Jul 26, 2024

@AbrilRBS I forgot that older versions of asio-grpc are not compatible with the latest version of asio. What to do now?

@weatherhead99
Copy link
Contributor

@Tradias can I suggest that you simply conditionally branch the requirements for the older version in the requirements() method?

@conan-center-bot

This comment has been minimized.

@Tradias
Copy link
Contributor Author

Tradias commented Aug 12, 2024

@AbrilRBS I addressed the issues that came with the version bump of dependencies. Any more concerns?

@Tradias Tradias changed the title asio-grpc: add version 3.1.0 asio-grpc: add version 3.2.0 Sep 16, 2024
@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

All green in build 10 (2916665601d235975096d0d68cdc6145287493d0):

  • asio-grpc/2.9.2:
    Built 7 packages out of 11 (All logs)

  • asio-grpc/2.3.0:
    Built 7 packages out of 11 (All logs)

  • asio-grpc/2.7.0:
    Built 6 packages out of 11 (All logs)

  • asio-grpc/3.2.0:
    Built 5 packages out of 11 (All logs)

  • asio-grpc/2.5.1:
    Built 7 packages out of 11 (All logs)

  • asio-grpc/2.2.0:
    Built 7 packages out of 11 (All logs)

  • asio-grpc/2.6.0:
    Built 7 packages out of 11 (All logs)

  • asio-grpc/2.0.0:
    Built 7 packages out of 11 (All logs)

  • asio-grpc/1.7.0:
    Built 7 packages out of 11 (All logs)

  • asio-grpc/2.1.0:
    Built 7 packages out of 11 (All logs)

  • asio-grpc/2.4.0:
    Built 7 packages out of 11 (All logs)


Conan v2 pipeline ✔️

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

All green in build 10 (2916665601d235975096d0d68cdc6145287493d0):

  • asio-grpc/3.2.0:
    Built 4 packages out of 5 (All logs)

  • asio-grpc/2.9.2:
    Built 4 packages out of 5 (All logs)

  • asio-grpc/2.7.0:
    Built 3 packages out of 5 (All logs)

  • asio-grpc/2.4.0:
    Built 4 packages out of 5 (All logs)

  • asio-grpc/2.5.1:
    Built 4 packages out of 5 (All logs)

  • asio-grpc/2.6.0:
    Built 4 packages out of 5 (All logs)

  • asio-grpc/2.3.0:
    Built 4 packages out of 5 (All logs)

  • asio-grpc/2.2.0:
    Built 4 packages out of 5 (All logs)

  • asio-grpc/2.0.0:
    Built 4 packages out of 5 (All logs)

  • asio-grpc/1.7.0:
    Built 4 packages out of 5 (All logs)

  • asio-grpc/2.1.0:
    Built 4 packages out of 5 (All logs)

@Tradias
Copy link
Contributor Author

Tradias commented Nov 30, 2024

@jcar87 This pr has been open for quite a while now, any chance to finally get it merged?

@Tradias Tradias changed the title asio-grpc: add version 3.2.0 asio-grpc: add version 3.4.1 Feb 21, 2025
@jcar87 jcar87 merged commit 8d392de into conan-io:master Feb 27, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants