Skip to content

libdecor: Add recipe #22387

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 26 commits into
base: master
Choose a base branch
from
Open

libdecor: Add recipe #22387

wants to merge 26 commits into from

Conversation

jwillikers
Copy link
Contributor

@jwillikers jwillikers commented Jan 16, 2024

Specify library name and version: libdecor/0.2.2

libdecor is a library for adding client-side decorations in Wayland.

This package is a dependency for mesa-demos and version 3.3.9 of GLFW.

Requires:


@conan-center-bot

This comment has been minimized.

@jwillikers
Copy link
Contributor Author

Blocked until #20795 can be merged.

@conan-center-bot

This comment has been minimized.

@jwillikers jwillikers mentioned this pull request Jan 17, 2024
4 tasks
@conan-center-bot

This comment has been minimized.

@conan-center-bot conan-center-bot added the Version conflict There is a version conflict when solving the dependencies graph label Jan 31, 2024
@conan-center-bot

This comment has been minimized.

@jwillikers
Copy link
Contributor Author

Blocked by libxft, requires #17485

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@jwillikers
Copy link
Contributor Author

Requires #22920 and #22696 to fix dependency conflicts.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@jwillikers
Copy link
Contributor Author

This library can be a dependency in SDL, so it would be beneficial to get it approved. I see that it hangs due to missing gtk/system binary. Can the package live well and prosper with it disabled? SDL will use with_dbus=True and do not need gtk.

I think getting a team member review is likely a bigger blocker than the missing dependency for gtk, which is likely fairly trivial to fix on the CCI side.

Copy link
Member

@AbrilRBS AbrilRBS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your patience while we circled back to this - There's one minor think I need to check with the team regarding which flavour of dep option configuration we prefer here, but other than that this looks good, will let you know tomorrow once I ask the team :)

Will build the missing binary meanwhile

@AbrilRBS
Copy link
Member

AbrilRBS commented Jun 3, 2024

Oh right, just realized that this mising binary will be a bit hard to implement with the current pipeline, as it only builds the default options! So it's a bit hard to move forward with the gtk version 3 requirement, but will also ask around, see what can be done!

@jwillikers
Copy link
Contributor Author

@AbrilRBS I've defaulted the with_gtk option to False for CCI.

@conan-center-bot conan-center-bot removed Failed Missing dependencies Build failed due missing dependencies in Conan Center labels Jul 11, 2024
@conan-center-bot
Copy link
Contributor

Conan v1 pipeline ✔️

All green in build 20 (00ac9a7cfea6734b37912fddbee885bf399073d5):

  • libdecor/0.2.2:
    All packages built successfully! (All logs)

Conan v2 pipeline ✔️

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

All green in build 20 (00ac9a7cfea6734b37912fddbee885bf399073d5):

  • libdecor/0.2.2:
    All packages built successfully! (All logs)

@joakimono
Copy link
Contributor

Any update on this PR?

danimtb
danimtb previously approved these changes Nov 20, 2024
@AbrilRBS AbrilRBS assigned danimtb and unassigned AbrilRBS Dec 4, 2024
Copy link
Contributor

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale label Mar 11, 2025
@AbrilRBS
Copy link
Member

AbrilRBS commented Mar 15, 2025

Don't close this please :)

We're working on it

Copy link
Contributor

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale label Apr 15, 2025
@jcar87 jcar87 removed the stale label Apr 15, 2025
Copy link
Contributor

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale label May 16, 2025
@jcar87 jcar87 removed the stale label May 29, 2025
Copy link
Contributor

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale label Jun 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants