Skip to content

pcl: add v1.14.0, use llvm-openmp for OpenMP #22152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 24 commits into from

Conversation

valgur
Copy link

@valgur valgur commented Jan 4, 2024

I scanned the diff against previous version and there were no changes to the list of components or their dependencies, either internal or external ones.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

Copy link
Member

@AbrilRBS AbrilRBS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we split the PR into the new version stuff, and the llvm-openmp one until we figure that one out?

@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

Warning

Conan Center will stop receiving updates for Conan 1.x packages soon - please see announcement.

All green in build 23 (0ac9bdb3c3e4a0e9b5ca13c8e7e03f737838d1d2):

  • pcl/1.14.1:
    Built 20 packages out of 22 (All logs)

  • pcl/1.13.1:
    Built 20 packages out of 22 (All logs)


Conan v2 pipeline ✔️

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

All green in build 23 (0ac9bdb3c3e4a0e9b5ca13c8e7e03f737838d1d2):

  • pcl/1.14.1:
    Built 9 packages out of 10 (All logs)

  • pcl/1.13.1:
    Built 9 packages out of 10 (All logs)

@valgur
Copy link
Author

valgur commented Oct 3, 2024

@AbrilRBS Ok, I reverted most of the OpenMP-related changes. I only kept the use of more correct and robust OpenMP linker and cxx flags instead of adding it as a system lib (the name of which is not fixed on MSVC, for example).

@shkwon98
Copy link

shkwon98 commented Nov 15, 2024

@valgur Hi, as a PCL user, thank you for your efforts in supporting conan.
Currently, 1.13.1, the only PCL version officially supported by conan, has a problem with Boost dependencies when building the pcl_gpu_containers target. This issue appears to have been resolved in 1.14.0-rc1, so support in conan is needed.

Looking at the above history, it seems that the check failed in the Pre-Checks step because of using the pre-release version of qhull. Is there a particular reason why you did not use version 8.0.1?

@valgur
Copy link
Author

valgur commented Nov 15, 2024

The libqhull PR #24532 should be merged first. PCL links against the re-entrant libqhull_r library, but the libqhull recipe does not correctly distinguish between the reentrant and non-reentrant variants in package_info() currently.

@perseoGI perseoGI removed their assignment Dec 3, 2024
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Martin Valgur seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@conan-center-build-service conan-center-build-service bot locked as off-topic and limited conversation to collaborators Mar 17, 2025
@valgur valgur deleted the update/pcl branch April 11, 2025 16:58
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants