-
Notifications
You must be signed in to change notification settings - Fork 2k
getdns: migrate to Conan v2, bump to v1.7.3 #21389
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
25c4f69
to
0b89c31
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
0b89c31
to
423eac2
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
fbb5e35
to
8a51ac1
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Signed-off-by: Uilian Ries <[email protected]>
Signed-off-by: Uilian Ries <[email protected]>
Signed-off-by: Uilian Ries <[email protected]>
Signed-off-by: Uilian Ries <[email protected]>
Signed-off-by: Uilian Ries <[email protected]>
Signed-off-by: Uilian Ries <[email protected]>
Signed-off-by: Uilian Ries <[email protected]>
I did some changes over this PR, including:
|
This comment has been minimized.
This comment has been minimized.
Signed-off-by: Uilian Ries <[email protected]>
… into migrate/getdns
Signed-off-by: Uilian Ries <[email protected]>
This comment has been minimized.
This comment has been minimized.
uilianries
previously approved these changes
Sep 6, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
LGTM as well. Thanks! |
Signed-off-by: Uilian Ries <[email protected]>
uilianries
approved these changes
Sep 6, 2024
AbrilRBS
approved these changes
Sep 6, 2024
Conan v1 pipeline ✔️All green in build 7 (
Conan v2 pipeline ✔️
All green in build 6 (
|
OMGtechy
pushed a commit
to OMGtechy/conan-center-index
that referenced
this pull request
Dec 31, 2024
* getdns: migrate to Conan v2 * getdns: bump deps * getdns: bump to 1.7.3, finish migration * getdns: temporarily disable libidn2 * getdns: bump cmake, remove pkg-config * getdns: check that OpenSSL configuration has not failed * getdns: don't need to use cache_variables CMake is 3.20+. * getdns: temporarily print detailed CMake logs * getdns: add Windows system libs * getdns: set CMAKE_TRY_COMPILE_CONFIGURATION * getdns: fix Windows build * getdns: disable libidn2 for now * getdns: fix Windows build * Use CMAKE_PROJECT_INCLUDE Signed-off-by: Uilian Ries <[email protected]> * Avoid capturing network on test package Signed-off-by: Uilian Ries <[email protected]> * Remove option for gnutls Signed-off-by: Uilian Ries <[email protected]> * Remove stub option Signed-off-by: Uilian Ries <[email protected]> * Enable libidn2 by default Signed-off-by: Uilian Ries <[email protected]> * ignore incompatible pointer type Signed-off-by: Uilian Ries <[email protected]> * Import libidn2 defines Signed-off-by: Uilian Ries <[email protected]> * Make CMaktoolchain compatible to Conan 1.x Signed-off-by: Uilian Ries <[email protected]> * Inject libidn2 defines to executables Signed-off-by: Uilian Ries <[email protected]> * Add todo comment for future refactor Signed-off-by: Uilian Ries <[email protected]> --------- Signed-off-by: Uilian Ries <[email protected]> Co-authored-by: Uilian Ries <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.