Skip to content

openvdb: migrate to Conan v2 #18891

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 27 commits into from
Mar 23, 2024
Merged

openvdb: migrate to Conan v2 #18891

merged 27 commits into from
Mar 23, 2024

Conversation

valgur
Copy link
Contributor

@valgur valgur commented Jul 24, 2023

No description provided.

@ghost
Copy link

ghost commented Jul 24, 2023 •
edited by ghost
Loading

I detected other pull requests that are modifying openvdb/all recipe:

This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there.

@ghost ghost mentioned this pull request Jul 24, 2023
Closed
@prince-chrismc prince-chrismc mentioned this pull request Jul 24, 2023
Open
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@valgur
Copy link
Contributor Author

valgur commented Aug 23, 2023 •
edited
Loading

TODO:

  • add bison and flex deps for ax.

@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@valgur valgur closed this Sep 15, 2023
@valgur valgur reopened this Sep 15, 2023
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@franramirez688 franramirez688 self-assigned this Oct 17, 2023
@ghost ghost mentioned this pull request Oct 18, 2023
Merged
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@perseoGI
Copy link
Contributor

perseoGI commented Feb 7, 2024

Any update on this?

@perseoGI
Copy link
Contributor

perseoGI commented Feb 7, 2024

@valgur why have you removed v8.0.1?

@valgur
Copy link
Contributor Author

valgur commented Feb 7, 2024

@perseoGI If I recall correctly, it's CMake parameters were considerably different from newer versions and it did not seem worthwhile to keep supporting it. Do you need v8, specifically?

AbrilRBS
AbrilRBS reviewed Mar 22, 2024
View reviewed changes
Copy link
Member

@AbrilRBS AbrilRBS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Sorry for the delay on getting this reviewed, looks good, I only have a few questions :)

recipes/openvdb/all/conanfile.py Outdated
if self.options.with_log4cplus:
self.requires("log4cplus/2.0.7")
# TODO: OpenVDB requires log4cplus v1.*, which is not available in CCI
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does this one mean? 1.2.2 does exist, so what's the comment referring to?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I added the v1.2.2 in a later PR (#21904). :)
I'll update the recipe.

franramirez688
franramirez688 reviewed Mar 22, 2024
View reviewed changes
Copy link
Contributor

@franramirez688 franramirez688 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks great! Some minor comments

@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

All green in build 2 (33b2ad4a231d2089fd9997b3ca389b4d8e4e58ac):

  • openvdb/10.1.0:
    All packages built successfully! (All logs)

  • openvdb/9.1.0:
    All packages built successfully! (All logs)

  • openvdb/11.0.0:
    All packages built successfully! (All logs)

Conan v2 pipeline ✔️

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

All green in build 2 (33b2ad4a231d2089fd9997b3ca389b4d8e4e58ac):

  • openvdb/11.0.0:
    All packages built successfully! (All logs)

  • openvdb/9.1.0:
    All packages built successfully! (All logs)

  • openvdb/10.1.0:
    All packages built successfully! (All logs)

@conan-center-bot conan-center-bot merged commit 3079044 into conan-io:master Mar 23, 2024
Ahajha pushed a commit to Ahajha/conan-center-index that referenced this pull request Apr 6, 2024
@valgur @Ahajha
(conan-io#18891) openvdb: migrate to Conan v2
b7a111c 
* openvdb: migrate to Conan v2

* openvdb: the patch is no longer required

* openvdb: add v8.2.0

Newer versions require considerable amounts of memory to build, probably too much for the CI. More than 1.5 GB per core.

* openvdb: bump deps, use cache_variables

* openvdb: remove broken minimum TBB version check

* openvdb: enable v9, v10, expose all available options, fix imath use

* openvdb: add and disable use_explicit_instantiation to limit memory usage during build

* openvdb: disable options not available in older versions

* openvdb: require flex and bison for build_ax

* openvdb: backport a bugfix for a build issue

* openvdb: bump versions

* openvdb: openexr requires transitive_libs=True

* openvdb: use imath instead of openexr for newer versions

* openvdb: use strict version checking

* openvdb: set use_imath_half=True

To fix
error LNK2001: unresolved external symbol "__declspec(dllimport) private: static unsigned short const * const half::_eLut"
etc on MSVC.

* openvdb: bump deps

* openvdb: add v10.1.0

* openvdb: drop v8.0.1

* openvdb: add v11.0.0

* openvdb: fix C++ standard in test_package

* openvdb: drop v8

* openvdb: enable log4cplus by default, bump deps

* openvdb: deprecation warning for with_exr

* openvdb: disable log4cplus

* openvdb: don't need cache_variables
@valgur valgur deleted the migrate/openvdb branch April 10, 2025 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@franramirez688 franramirez688 franramirez688 approved these changes

@jwillikers jwillikers jwillikers approved these changes

@danimtb danimtb Awaiting requested review from danimtb

@AbrilRBS AbrilRBS Awaiting requested review from AbrilRBS

Assignees

@franramirez688 franramirez688

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@valgur @conan-center-bot @perseoGI @franramirez688 @AbrilRBS @jwillikers