Skip to content

libtommath: migrate to Conan v2 #18852

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 36 commits into from
Closed

Conversation

valgur
Copy link

@valgur valgur commented Jul 23, 2023

Continues from #16558 with minimal changes (also resolves #16558).

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@stale
Copy link

stale bot commented Sep 17, 2023

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added stale and removed stale labels Sep 17, 2023
@conan-center-bot

This comment has been minimized.

@valgur valgur force-pushed the migrate/libtommath branch from c9d4fa1 to 2305207 Compare November 2, 2023 05:33
@conan-center-bot

This comment has been minimized.

@valgur valgur force-pushed the migrate/libtommath branch from 2305207 to 7f1cf27 Compare November 27, 2023 15:40
@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@ghost ghost mentioned this pull request Feb 15, 2024
3 tasks
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

both all and cmake folders are using CMake. Please, merge them if possible.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea. Done.

@valgur valgur requested a review from AbrilRBS September 3, 2024 21:29
@uilianries uilianries self-assigned this Sep 23, 2024
Copy link
Contributor

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale label Oct 24, 2024
@valgur
Copy link
Author

valgur commented Oct 24, 2024

.

@github-actions github-actions bot removed the stale label Oct 25, 2024
Copy link
Contributor

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale label Nov 24, 2024
@valgur
Copy link
Author

valgur commented Nov 24, 2024

.

@github-actions github-actions bot removed the stale label Nov 25, 2024
@AbrilRBS AbrilRBS removed their assignment Dec 3, 2024
Copy link
Contributor

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale label Dec 26, 2024
@valgur
Copy link
Author

valgur commented Dec 26, 2024

.

@github-actions github-actions bot removed the stale label Dec 27, 2024
The project is capable to export symbols to generate a .dll

Signed-off-by: Uilian Ries <[email protected]>
Signed-off-by: Uilian Ries <[email protected]>
Signed-off-by: Uilian Ries <[email protected]>
Signed-off-by: Uilian Ries <[email protected]>
uilianries
uilianries previously approved these changes Jan 24, 2025
Copy link
Member

@uilianries uilianries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@valgur Thank you for continuing this PR.

I did a few changes on this PR, in order to simplify it:

  • The version 1.3.0 includes CMakeLists.txt in its root folder. Supporting only this version simplifies the recipes a lot too.
  • The upstream can not export symbols on Windows to generate a .dll. So I dropped shared library as well on Windows
  • Simplified the test package to only validate the library.
  • Dropped Windows debug support for now. First, CCI don't build package on Debug due the lower number the downloads and other topics, so we can not validate. Second, the upstream recommends inject /O1 instead of the default Cmake configuration /Og. In case an user really need Debug build type, then an issue can be opened to discuss this topic, but would need to pass CMAKE_C_FLAGS_DEBUG or similar.

@uilianries uilianries dismissed their stale review January 30, 2025 07:47

Doing extra review.

@CLAassistant
Copy link

CLAassistant commented Mar 9, 2025

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
3 out of 4 committers have signed the CLA.

✅ prince-chrismc
✅ jowr
✅ uilianries
❌ Martin Valgur


Martin Valgur seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@conan-center-build-service conan-center-build-service bot locked as off-topic and limited conversation to collaborators Mar 17, 2025
@valgur valgur deleted the migrate/libtommath branch April 10, 2025 19:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants