-
Notifications
You must be signed in to change notification settings - Fork 2k
libtool: fix windows x86 build #18088
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I detected other pull requests that are modifying libtool/all recipe: This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there. |
@@ -92,6 +93,20 @@ def generate(self): | |||
|
|||
tc = AutotoolsToolchain(self) | |||
|
|||
if cross_building(self) and is_msvc(self): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if cross_building(self) and is_msvc(self): | |
if cross_building(self) and (is_msvc(self) or self.settings.compiler == "clang"): |
Maybe it should be like that?
if host_arch and build_arch: | ||
host = f"{host_arch}-w64-mingw32" | ||
build = f"{build_arch}-w64-mingw32" | ||
tc.configure_args.extend([ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it be better to use tc.update_configure_args
or extend is fine?
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
@maksim-petukhov Thank you for your contribution. As you can read in supported configurations document, the CCI does not build x86, so we can't validate your changes. Could you please share with us a full log of your build on Windows x86, so we could some prof that's have your desired effect? |
Conan v1 pipeline ✔️All green in build 3 (
Conan v2 pipeline ❌
The v2 pipeline failed. Please, review the errors and note this will be required for pull requests to be merged in the near future. See details:Failure in build 2 (
Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability. |
Just triggered an internal CI build to generate libtool. The result should be available at https://c3i.jfrog.io/c3i/misc-v2/summary.html?json=https://c3i.jfrog.io/c3i/misc-v2/logs/prod-v2/TapaholesRepo/54/summary.json as soon as it finishes (it may take few hours). |
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
This pull request has been automatically closed because it has not had recent activity. Thank you for your contributions. |
Specify library name and version: libtool/*
The same problem as in #18086
Honorable mention: conan-io/conan#12546 & conan-io/conan#7460