Skip to content

libtool: fix windows x86 build #18088

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

maksim-petukhov
Copy link
Contributor

Specify library name and version: libtool/*

The same problem as in #18086

Honorable mention: conan-io/conan#12546 & conan-io/conan#7460


@ghost
Copy link

ghost commented Jun 27, 2023

I detected other pull requests that are modifying libtool/all recipe:

This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there.

@@ -92,6 +93,20 @@ def generate(self):

tc = AutotoolsToolchain(self)

if cross_building(self) and is_msvc(self):
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if cross_building(self) and is_msvc(self):
if cross_building(self) and (is_msvc(self) or self.settings.compiler == "clang"):

Maybe it should be like that?

if host_arch and build_arch:
host = f"{host_arch}-w64-mingw32"
build = f"{build_arch}-w64-mingw32"
tc.configure_args.extend([
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be better to use tc.update_configure_args or extend is fine?

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

1 similar comment
@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@uilianries
Copy link
Member

@maksim-petukhov Thank you for your contribution. As you can read in supported configurations document, the CCI does not build x86, so we can't validate your changes. Could you please share with us a full log of your build on Windows x86, so we could some prof that's have your desired effect?

@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

All green in build 3 (070b49feb415e0ccfb9a83ffb5ea6c4ac62c87ab):

  • libtool/2.4.6@:
    All packages built successfully! (All logs)

  • libtool/2.4.7@:
    All packages built successfully! (All logs)


Conan v2 pipeline ❌

Regression: Conan v2 builds are mandatory and they are required for the PR to be merged, because this recipe worked with Conan v2 previously.

The v2 pipeline failed. Please, review the errors and note this will be required for pull requests to be merged in the near future.

See details:

Failure in build 2 (070b49feb415e0ccfb9a83ffb5ea6c4ac62c87ab):

  • libtool/2.4.6@:
    Didn't run or was cancelled before finishing

  • libtool/2.4.7@:
    CI failed to create some packages (All logs)

    Logs for packageID abe5e2b04ea92ce2ee91bc9834317dbe66628206:
    [settings]
    arch=x86_64
    build_type=Release
    compiler=gcc
    compiler.cppstd=17
    compiler.libcxx=libstdc++11
    compiler.version=11
    os=Linux
    [options]
    */*:shared=True
    
    [...]
    ======== Launching test_package ========
    
    ======== Computing dependency graph ========
    Graph root
        libtool/2.4.7 (test package): /home/conan/w/prod-v2/BuildSingleReference/cci-dee719c3/recipes/libtool/all/test_package/conanfile.py
    Requirements
        autoconf/2.71#ce232afdcd21d1269419c355375731e6 - Cache
        automake/1.16.5#058bda3e21c36c9aa8425daf3c1faf50 - Cache
        libtool/2.4.7#3185591c30a68209b96a8e6d4f057050 - Cache
        m4/1.4.19#c1c4b1ee919e34630bb9b50046253d3c - Cache
    Build requirements
        autoconf/2.71#ce232afdcd21d1269419c355375731e6 - Cache
        automake/1.16.5#058bda3e21c36c9aa8425daf3c1faf50 - Cache
        gnu-config/cci.20210814#15c3bf7dfdb743977b84d0321534ad90 - Cache
        libtool/2.4.7#3185591c30a68209b96a8e6d4f057050 - Cache
        m4/1.4.19#c1c4b1ee919e34630bb9b50046253d3c - Cache
    
    ======== Computing necessary packages ========
    Requirements
        autoconf/2.71#ce232afdcd21d1269419c355375731e6:da39a3ee5e6b4b0d3255bfef95601890afd80709#f23fbd87879937e4deeda004f0c87d46 - Cache
        automake/1.16.5#058bda3e21c36c9aa8425daf3c1faf50:9a4eb3c8701508aa9458b1a73d0633783ecc2270#9719e51a6a62041af6a63e00eef35434 - Cache
        libtool/2.4.7#3185591c30a68209b96a8e6d4f057050:abe5e2b04ea92ce2ee91bc9834317dbe66628206#3c4ab76b815865c377094270a6bd7a66 - Cache
        m4/1.4.19#c1c4b1ee919e34630bb9b50046253d3c:3593751651824fb813502c69c971267624ced41a#c69dc2230d016a77b5514d9916b14714 - Cache
    Build requirements
        autoconf/2.71#ce232afdcd21d1269419c355375731e6:da39a3ee5e6b4b0d3255bfef95601890afd80709#f23fbd87879937e4deeda004f0c87d46 - Cache
        automake/1.16.5#058bda3e21c36c9aa8425daf3c1faf50:9a4eb3c8701508aa9458b1a73d0633783ecc2270#9719e51a6a62041af6a63e00eef35434 - Cache
        libtool/2.4.7#3185591c30a68209b96a8e6d4f057050:b647c43bfefae3f830561ca202b6cfd935b56205 - Missing
        m4/1.4.19#c1c4b1ee919e34630bb9b50046253d3c:3593751651824fb813502c69c971267624ced41a#c69dc2230d016a77b5514d9916b14714 - Cache
    Skipped binaries
        gnu-config/cci.20210814
    
    ======== Installing packages ========
    ERROR: Missing binary: libtool/2.4.7:b647c43bfefae3f830561ca202b6cfd935b56205
    
    libtool/2.4.7: WARN: Can't find a 'libtool/2.4.7' package binary 'b647c43bfefae3f830561ca202b6cfd935b56205' for the configuration:
    [settings]
    arch=x86_64
    build_type=Release
    compiler=gcc
    compiler.version=11
    os=Linux
    [options]
    fPIC=True
    shared=False
    
    ERROR: Missing prebuilt package for 'libtool/2.4.7'
    Check the available packages using 'conan list libtool/2.4.7:* -r=remote'
    'conan test' tested packages must exist, and '--build' argument is used only for the 'test_package' dependencies, not for the tested dependencies
    
    More Info at 'https://docs.conan.io/2/knowledge/faq.html#error-missing-prebuilt-package'
    

Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability.

@uilianries
Copy link
Member

Just triggered an internal CI build to generate libtool. The result should be available at https://c3i.jfrog.io/c3i/misc-v2/summary.html?json=https://c3i.jfrog.io/c3i/misc-v2/logs/prod-v2/TapaholesRepo/54/summary.json as soon as it finishes (it may take few hours).

@ghost ghost mentioned this pull request Aug 30, 2023
3 tasks
@stale
Copy link

stale bot commented Oct 15, 2023

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

Copy link
Contributor

This pull request has been automatically closed because it has not had recent activity. Thank you for your contributions.

@github-actions github-actions bot closed this Mar 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants