Adding Botan 3.0.0 recipe #17364

Maaown · 2023-05-02T09:32:40Z

Specify library name and version: botan/3.0.0

fixes #17247

I've read the contributing guidelines.
I've used a recent Conan client version close to the currently deployed.
I've tried at least one configuration locally with the conan-center hook activated.

CLAassistant · 2023-05-02T09:32:46Z

All committers have signed the CLA.

Maaown · 2023-05-02T09:40:12Z

fixes #17247

memsharded · 2023-05-10T15:23:48Z

I have contributed some further things that would be necessary to modernize this recipe in 8cd739a:

We cannot drop yet support for 1.X, so changed to required_conan_version = ">=1.55"
There is a conan Version that should be used instead of the LooseVersion.
Using ``layout()```
Using apply_conandata_patches(self) and export_conandata_patches(self)

There are still other things that need to be fixed:

Using proper generate(), removing all deps_cpp_info references
Removing tools.vcvars, most likely using VCVars generator in generate()

lieser · 2023-05-22T09:05:14Z

@Maaown do you want me to help here? I could rebase my changes onto your PR, and try to push it into your branch.

Maaown · 2023-05-22T19:54:44Z

@lieser That would be greatly appreciated, i'm not at all familiar with building on windows so i may need help on that part.
Otherwise, if you see some improvements, go for it.
I'm in a rush these days, i'll check what you've done the sooner i can.

lieser · 2023-05-23T12:11:09Z

I rebased most of my changes and pushed them to https://github.com/lieser/conan-center-index/tree/17247-botan-upgrade-conanfile-2.0. Did not have permissions to push into your branch. Maybe you could give me access? Or just pull them yourself.

Did you test that reading the environment variables with Environment actually works? Then I tried it a few weeks ago it seemed to fail to read them, regardless of if they there defined on the command line or the conan profile. I had to use os.getenv().
But bevor I change it to use os.getenv() I want to make sure I did not just fail to use it correctly.

lieser · 2023-05-23T12:12:11Z

recipes/botan/all/conanfile.py


    def package_info(self):
-        major_version = tools.Version(self.version).major
+        major_version = self.version.split('.')[0]
        self.cpp_info.set_property("pkg_config_name", f"botan-{major_version}")
        self.cpp_info.names["pkg_config"] = f"botan-{major_version}"


From my understanding this is redundant with the self.cpp_info.set_property line above, and can be removed.

lieser · 2023-05-23T12:18:51Z

recipes/botan/all/conanfile.py

-        # Required to build at least 2.12.1
-        return "sources"
+    def layout(self):
+        basic_layout(self, src_folder="src")


Is there a reason you changed sources to src? I slightly prefer the old sources, to make sure it is not confused to be related with the src folder inside the botan repository.

Also maybe place it between def validate() and def source(), so they are order according to the order in which they are called.

Linter will complain if it is not src. Moved the function in my PR.

lieser · 2023-05-23T12:28:25Z

recipes/botan/all/conanfile.py

-        for patch in self.conan_data.get('patches', {}).get(self.version, []):
-            tools.patch(**patch)
-        with tools.chdir(self._source_subfolder):
+        apply_conandata_patches(self)


Maybe a Conan expert can answer this with a reason why:
Is build() or source() the best place to put this?

In my change I moved this to source(), because the Boost recipe calls it there too, and it made sense to me conceptually. But in most recipe it seems to be called in the build() method.

lieser · 2023-05-23T12:35:38Z

recipes/botan/all/conanfile.py

                # Required, see https://github.com/conan-io/conan-center-index/pull/3456
                macos_min_version = tools.apple_deployment_target_flag(self.settings.os,


Unsure how this is best resolved. apple_deployment_target_flag() seems to be currently private because of a missing use case.

Don't know if we have here a use case, or if there is not a modern and better way. E.g. by using the AutoToolsBuildEnvironment, the only place there apple_deployment_target_flag() is called internally.

Used AutotoolsToolchain(self).apple_min_version_flag as a workaround.

ghost · 2023-06-27T14:12:50Z

I detected other pull requests that are modifying botan/all recipe:

Adding Botan 3.0.0 recipe and make it compatible with Conan 2.x #18079

This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there.

lieser · 2023-06-28T08:58:02Z

I created a second draft PR there I can push into to continue working on this (#18079).

@Maaown As my PR is currently based on yours, could you please still sign the CLA as a preparation for it to get merged?

Maaown · 2023-06-28T12:22:17Z

I created a second draft PR there I can push into to continue working on this (#18079).

@Maaown As my PR is currently based on yours, could you please still sign the CLA as a preparation for it to get merged?

Should be done by now

conan-center-bot · 2023-07-24T11:25:47Z

Conan v1 pipeline ❌

Sorry, the system is under maintenance and it doesn't accept builds right now.
Please, check https://status.conan.io to obtain more information.
Thanks for your understanding and help with the Conan Center Index!

Conan v2 pipeline ❌

Note: Conan v2 builds may be required once they are on the v2 ready list

The v2 pipeline failed. Please, review the errors and note this will be required for pull requests to be merged in the near future.

See details:

Sorry, the system is under maintenance and it doesn't accept builds right now.
Please, check https://status.conan.io to obtain more information.
Thanks for your understanding and help with the Conan Center Index!

stale · 2023-10-15T12:07:21Z

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

github-actions · 2024-02-22T06:35:39Z

This pull request has been automatically closed because it has not had recent activity. Thank you for your contributions.

conan-center-bot added the User-approval pending label May 2, 2023

This comment has been minimized.

Sign in to view

Maaown force-pushed the 17247-botan-upgrade-conanfile-2.0 branch from 22fc918 to ef8a4cd Compare May 2, 2023 12:35

This comment has been minimized.

Sign in to view

This was referenced May 2, 2023

Updatable recipes qchateau/conan-center-bot#1

Open

[request] Updatable recipes #3470

Closed

Maaown force-pushed the 17247-botan-upgrade-conanfile-2.0 branch from ef8a4cd to 9c03cdd Compare May 3, 2023 07:42

This comment has been minimized.

Sign in to view

prince-chrismc mentioned this pull request May 6, 2023

[bot] Update authorized users list (2023-05-04) #17388

Merged

This comment has been minimized.

Sign in to view

Maaown force-pushed the 17247-botan-upgrade-conanfile-2.0 branch from b143dc4 to fec14ec Compare May 9, 2023 13:32

This comment has been minimized.

Sign in to view

Maaown force-pushed the 17247-botan-upgrade-conanfile-2.0 branch from 9d019b8 to fa9ec63 Compare May 9, 2023 14:19

This comment has been minimized.

Sign in to view

Maaown added 5 commits May 9, 2023 17:01

adding Botan 3.0.0 recipe

fa21153

updated to conan 2

cb2bf12

ci lint fix

292b9be

ci lint fix

651e324

ci lint fix

69015fc

Maaown force-pushed the 17247-botan-upgrade-conanfile-2.0 branch from 96a2343 to 69015fc Compare May 9, 2023 15:01

This comment has been minimized.

Sign in to view

replacing version check

8427f57

This comment has been minimized.

Sign in to view

memsharded self-assigned this May 10, 2023

some more fixes to be ready for 2.0

8cd739a

conan-center-bot removed the User-approval pending label May 10, 2023

fixes

6e2d05f

This comment has been minimized.

Sign in to view

lieser reviewed May 23, 2023

View reviewed changes

lieser mentioned this pull request May 23, 2023

[package] botan/2.19.3 Unknown -fPIC flag #15133

Closed

conan-center-bot added Unexpected Error and removed Failed labels Jun 22, 2023

This comment has been minimized.

Sign in to view

lieser mentioned this pull request Jun 27, 2023

Adding Botan 3.0.0 recipe and make it compatible with Conan 2.x #18079

Merged

3 tasks

ghost mentioned this pull request Jun 27, 2023

[service] Potentially conflicting recipes #3571

Closed

conan-center-bot added Failed and removed Unexpected Error labels Jun 28, 2023

This comment has been minimized.

Sign in to view

conan-center-bot added Service Under Maintenance and removed Failed labels Jul 24, 2023

stale bot added the stale label Oct 15, 2023

ghost mentioned this pull request Oct 18, 2023

Bump botan's zlib requirement to [>=1.2.11 <2] range (v1 only) #20668

Closed

This was referenced Feb 21, 2024

botan: add version 2.19.4 #22836

Merged

botan: add version 3.3.0 #22837

Merged

botan: remove no-op option #22841

Merged

github-actions bot closed this Feb 22, 2024

		# Required, see https://github.com/conan-io/conan-center-index/pull/3456
		macos_min_version = tools.apple_deployment_target_flag(self.settings.os,

Adding Botan 3.0.0 recipe #17364

Adding Botan 3.0.0 recipe #17364

Uh oh!

Conversation

Maaown commented May 2, 2023 • edited by prince-chrismc Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

CLAassistant commented May 2, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment has been minimized.

Maaown commented May 2, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

memsharded commented May 10, 2023

Uh oh!

This comment has been minimized.

lieser commented May 22, 2023

Uh oh!

Maaown commented May 22, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

lieser commented May 23, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

lieser May 23, 2023

Choose a reason for hiding this comment

Uh oh!

lieser Jul 10, 2023

Choose a reason for hiding this comment

Uh oh!

lieser May 23, 2023

Choose a reason for hiding this comment

Uh oh!

lieser Jun 30, 2023

Choose a reason for hiding this comment

Uh oh!

lieser May 23, 2023

Choose a reason for hiding this comment

Uh oh!

lieser May 23, 2023

Choose a reason for hiding this comment

Uh oh!

lieser Jun 30, 2023

Choose a reason for hiding this comment

Uh oh!

This comment has been minimized.

This comment has been minimized.

ghost commented Jun 27, 2023

Uh oh!

This comment has been minimized.

lieser commented Jun 28, 2023

Uh oh!

Maaown commented Jun 28, 2023

Uh oh!

conan-center-bot commented Jul 24, 2023

Conan v1 pipeline ❌

Conan v2 pipeline ❌

Uh oh!

stale bot commented Oct 15, 2023

Uh oh!

github-actions bot commented Feb 22, 2024

Uh oh!

Uh oh!

Maaown commented May 2, 2023 •

edited by prince-chrismc

Loading

CLAassistant commented May 2, 2023 •

edited

Loading

Maaown commented May 2, 2023 •

edited

Loading

Maaown commented May 22, 2023 •

edited

Loading

lieser commented May 23, 2023 •

edited

Loading