-
Notifications
You must be signed in to change notification settings - Fork 2k
opentelemetry-cpp: add version 1.8.2, update dependencies #15805
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This comment has been minimized.
This comment has been minimized.
I detected other pull requests that are modifying opentelemetry-cpp/all recipe: This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there. |
This comment has been minimized.
This comment has been minimized.
Make sure to comment in #4 |
7a41eff
to
3ca28f3
Compare
This comment has been minimized.
This comment has been minimized.
3ca28f3
to
0d3dca7
Compare
This comment has been minimized.
This comment has been minimized.
You need to wait #15980 has not merged |
Please do not force push 🙏 GitHub forces us to restart the review which is not fun! |
Ohh, sorry I didn't know that. |
There's merge conflicts FYI |
bdf8603
0d3dca7
to
bdf8603
Compare
Hi @prince-chrismc I had to rebase to merge the changes that were added into this recipe in the meantime since my PR was created. |
This comment has been minimized.
This comment has been minimized.
ef76c3e
to
2c5cddb
Compare
Hi all, I opened a Github issue recently related to an issue I discovered that was introduced to the package recipe recently. Namely, a change was made that to the recipe that caused Conan to build the example files in the OpenTelemetry repo. Unfortunately, there is a mistake in one of their example files that prevents it from building in C++ 20. Would the authors of this PR would consider updating it to turn off the building of the example files? cc @MrSparc @prince-chrismc @jwillikers Thank you! |
Seems like adding |
A PR about this topic was already raised: |
Yes, agreed, would be an easy fix. I have not tested it locally yet.
Ah, I missed that, thank you. |
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
@prince-chrismc can you trigger it again as some package dependencies were updated in the meantime? This PR was marked as stale. |
Any progress? |
You'll need to retrigger CI, close the pr wait 10s and then re-open it 🔁 Service is currently under maintenance so you should wait a day |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
All I wanted was to update a recipe to include 1.8.2 but not rewrite the entire cookbook... Now the old opentelemetry-cpp/1.4.1 failed because:
this is a never ending history :( |
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe this version is no longer important once 1.9.1 is out?
Conan v1 pipeline ❌Failure in build 14 (
Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability. Conan v2 pipeline ❌
The v2 pipeline failed. Please, review the errors and note this will be required for pull requests to be merged in the near future. See details:Failure in build 13 (
Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability. |
I agree, with a more recent version there is no reason to continue this PR. |
Specify library name and version: opentelemetry-cpp/*
This PR was based on toge PR: #15687 that was closed as outdated to be merged by this new one.