Skip to content

m4: use positional arguments when calling self.run() #15122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

jcar87
Copy link
Contributor

@jcar87 jcar87 commented Jan 5, 2023

Specify library name and version: m4/all

Fixes the following issue when testing the package with Conan 2, by using a positional argument for the output variable, instead of a name one (the name differs between Conan 1 and 2).

m4/1.4.19 (test package): Error in test() method, line 35
	self.run(f"m4 -P {self._m4_input_path}", output=output)
	TypeError: run() got an unexpected keyword argument 'output'

@jcar87 jcar87 requested a review from czoido January 5, 2023 15:25
@ghost
Copy link

ghost commented Jan 5, 2023

I detected other pull requests that are modifying m4/all recipe:

This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there.

@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline

All green in build 1 (46ce054f31fda4080507f91f21a26b1e8f1bcc76):

  • m4/1.4.18@:
    All packages built successfully! (All logs)

  • m4/1.4.19@:
    All packages built successfully! (All logs)


Conan v2 pipeline (informative, not required for merge)

Failure in build 1 (46ce054f31fda4080507f91f21a26b1e8f1bcc76):

  • m4/1.4.19@:
    CI failed to create some packages (All logs)

    Logs for packageID 3593751651824fb813502c69c971267624ced41a:
    [settings]
    arch=x86_64
    build_type=Release
    compiler=gcc
    compiler.libcxx=libstdc++11
    compiler.version=11
    os=Linux
    
    [...]
    installing /home/conan/w/prod-v2/BuildSingleReference/p/tmp/493daf7c0bae541c/b/src/po/hr.gmo as /home/conan/w/prod-v2/BuildSingleReference/p/tmp/493daf7c0bae541c/p//share/locale/hr/LC_MESSAGES/m4.mo
    installing /home/conan/w/prod-v2/BuildSingleReference/p/tmp/493daf7c0bae541c/b/src/po/id.gmo as /home/conan/w/prod-v2/BuildSingleReference/p/tmp/493daf7c0bae541c/p//share/locale/id/LC_MESSAGES/m4.mo
    installing /home/conan/w/prod-v2/BuildSingleReference/p/tmp/493daf7c0bae541c/b/src/po/ja.gmo as /home/conan/w/prod-v2/BuildSingleReference/p/tmp/493daf7c0bae541c/p//share/locale/ja/LC_MESSAGES/m4.mo
    installing /home/conan/w/prod-v2/BuildSingleReference/p/tmp/493daf7c0bae541c/b/src/po/ko.gmo as /home/conan/w/prod-v2/BuildSingleReference/p/tmp/493daf7c0bae541c/p//share/locale/ko/LC_MESSAGES/m4.mo
    installing /home/conan/w/prod-v2/BuildSingleReference/p/tmp/493daf7c0bae541c/b/src/po/nl.gmo as /home/conan/w/prod-v2/BuildSingleReference/p/tmp/493daf7c0bae541c/p//share/locale/nl/LC_MESSAGES/m4.mo
    installing /home/conan/w/prod-v2/BuildSingleReference/p/tmp/493daf7c0bae541c/b/src/po/pl.gmo as /home/conan/w/prod-v2/BuildSingleReference/p/tmp/493daf7c0bae541c/p//share/locale/pl/LC_MESSAGES/m4.mo
    installing /home/conan/w/prod-v2/BuildSingleReference/p/tmp/493daf7c0bae541c/b/src/po/pt_BR.gmo as /home/conan/w/prod-v2/BuildSingleReference/p/tmp/493daf7c0bae541c/p//share/locale/pt_BR/LC_MESSAGES/m4.mo
    installing /home/conan/w/prod-v2/BuildSingleReference/p/tmp/493daf7c0bae541c/b/src/po/ro.gmo as /home/conan/w/prod-v2/BuildSingleReference/p/tmp/493daf7c0bae541c/p//share/locale/ro/LC_MESSAGES/m4.mo
    installing /home/conan/w/prod-v2/BuildSingleReference/p/tmp/493daf7c0bae541c/b/src/po/ru.gmo as /home/conan/w/prod-v2/BuildSingleReference/p/tmp/493daf7c0bae541c/p//share/locale/ru/LC_MESSAGES/m4.mo
    installing /home/conan/w/prod-v2/BuildSingleReference/p/tmp/493daf7c0bae541c/b/src/po/sr.gmo as /home/conan/w/prod-v2/BuildSingleReference/p/tmp/493daf7c0bae541c/p//share/locale/sr/LC_MESSAGES/m4.mo
    installing /home/conan/w/prod-v2/BuildSingleReference/p/tmp/493daf7c0bae541c/b/src/po/sv.gmo as /home/conan/w/prod-v2/BuildSingleReference/p/tmp/493daf7c0bae541c/p//share/locale/sv/LC_MESSAGES/m4.mo
    installing /home/conan/w/prod-v2/BuildSingleReference/p/tmp/493daf7c0bae541c/b/src/po/uk.gmo as /home/conan/w/prod-v2/BuildSingleReference/p/tmp/493daf7c0bae541c/p//share/locale/uk/LC_MESSAGES/m4.mo
    installing /home/conan/w/prod-v2/BuildSingleReference/p/tmp/493daf7c0bae541c/b/src/po/vi.gmo as /home/conan/w/prod-v2/BuildSingleReference/p/tmp/493daf7c0bae541c/p//share/locale/vi/LC_MESSAGES/m4.mo
    installing /home/conan/w/prod-v2/BuildSingleReference/p/tmp/493daf7c0bae541c/b/src/po/zh_CN.gmo as /home/conan/w/prod-v2/BuildSingleReference/p/tmp/493daf7c0bae541c/p//share/locale/zh_CN/LC_MESSAGES/m4.mo
    installing /home/conan/w/prod-v2/BuildSingleReference/p/tmp/493daf7c0bae541c/b/src/po/zh_TW.gmo as /home/conan/w/prod-v2/BuildSingleReference/p/tmp/493daf7c0bae541c/p//share/locale/zh_TW/LC_MESSAGES/m4.mo
    if test "m4" = "gettext-tools"; then \
      /bin/mkdir -p /home/conan/w/prod-v2/BuildSingleReference/p/tmp/493daf7c0bae541c/p//share/gettext/po; \
      for file in Makefile.in.in remove-potcdate.sin quot.sed boldquot.sed [email protected] [email protected] insert-header.sin Rules-quot   Makevars.template; do \
        /usr/bin/install -c -m 644 /home/conan/w/prod-v2/BuildSingleReference/p/tmp/493daf7c0bae541c/b/src/po/$file \
    		    /home/conan/w/prod-v2/BuildSingleReference/p/tmp/493daf7c0bae541c/p//share/gettext/po/$file; \
      done; \
      for file in Makevars; do \
        rm -f /home/conan/w/prod-v2/BuildSingleReference/p/tmp/493daf7c0bae541c/p//share/gettext/po/$file; \
      done; \
    else \
      : ; \
    fi
    make[2]: Leaving directory '/home/conan/w/prod-v2/BuildSingleReference/p/tmp/493daf7c0bae541c/b/build-release/po'
    Making install in tests
    make[2]: Entering directory '/home/conan/w/prod-v2/BuildSingleReference/p/tmp/493daf7c0bae541c/b/build-release/tests'
    make  install-recursive
    make[3]: Entering directory '/home/conan/w/prod-v2/BuildSingleReference/p/tmp/493daf7c0bae541c/b/build-release/tests'
    Making install in .
    make[4]: Entering directory '/home/conan/w/prod-v2/BuildSingleReference/p/tmp/493daf7c0bae541c/b/build-release/tests'
    make[5]: Entering directory '/home/conan/w/prod-v2/BuildSingleReference/p/tmp/493daf7c0bae541c/b/build-release/tests'
    make[5]: Nothing to be done for 'install-exec-am'.
    make[5]: Nothing to be done for 'install-data-am'.
    make[5]: Leaving directory '/home/conan/w/prod-v2/BuildSingleReference/p/tmp/493daf7c0bae541c/b/build-release/tests'
    make[4]: Leaving directory '/home/conan/w/prod-v2/BuildSingleReference/p/tmp/493daf7c0bae541c/b/build-release/tests'
    make[3]: Leaving directory '/home/conan/w/prod-v2/BuildSingleReference/p/tmp/493daf7c0bae541c/b/build-release/tests'
    make[2]: Leaving directory '/home/conan/w/prod-v2/BuildSingleReference/p/tmp/493daf7c0bae541c/b/build-release/tests'
    make[1]: Leaving directory '/home/conan/w/prod-v2/BuildSingleReference/p/tmp/493daf7c0bae541c/b/build-release'
    m4/1.4.19 package(): Packaged 2 files: m4, COPYING
    m4/1.4.19: Package '3593751651824fb813502c69c971267624ced41a' created
    m4/1.4.19: Created package revision c69dc2230d016a77b5514d9916b14714
    m4/1.4.19: Full package reference: m4/1.4.19#ec4002e19cde0802f89204cab65f28f9:3593751651824fb813502c69c971267624ced41a#c69dc2230d016a77b5514d9916b14714
    m4/1.4.19: Package folder /home/conan/w/prod-v2/BuildSingleReference/p/5f86278700bb2ba5/p
    m4/1.4.19: Appending PATH environment variable: /home/conan/w/prod-v2/BuildSingleReference/p/5f86278700bb2ba5/p/bin
    WARN: The use of 'env_info' is deprecated in Conan 2.0 and will be removed in Conan 2.X. Please, update your recipes unless you are maintaining compatibility with Conan 1.X
    ERROR: m4/1.4.19: 'NoneType' object has no attribute 'append'. No default values are set for components. You are probably trying to manipulate a component attribute in the 'package_info' method without defining it previously
    
  • m4/1.4.18@:
    Didn't run or was cancelled before finishing


Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability.

@conan-center-bot conan-center-bot merged commit 44d4e9f into conan-io:master Jan 5, 2023
@jcar87 jcar87 deleted the maintenance/m4-conan2-fix-test-package branch January 6, 2023 08:58
AbrilRBS pushed a commit to AbrilRBS/conan-center-index that referenced this pull request Jan 16, 2023
datalogics-robb pushed a commit to datalogics-robb/conan-center-index that referenced this pull request Mar 6, 2023
…-index

* 'develop' of octocat.dlogics.com:datalogics/conan-center-index: (259 commits)
  Allow empty keys in dlproject.yaml for merging tasks
  (conan-io#15093) [libjpeg] Update sha256 for 9e
  (conan-io#15123) faac: add Visual Studio support + drop 1.28
  (conan-io#14103) gmp: conan v2 support
  (conan-io#14982) rapidyaml: add version 0.5.0
  (conan-io#15122) m4: use positional arguments when calling self.run()
  (conan-io#15091) catch2.x.x: Fix test_package for v2
  (conan-io#12938) capnproto: conan v2 support
  (conan-io#15097) http_parser: modernize
  (conan-io#15096) perlinnoise: add recipe
  (conan-io#15088) Make openexr v2 compatible
  (conan-io#15056) qt5: Apple OSs don't require CROSS_COMPILE option
  (conan-io#14974) libxshmfence: generate gcc11 binaries
  (conan-io#14903) arrow: remove patch for CMake
  (conan-io#14874) faac: conan v2 support
  (conan-io#13896) [gcc] Migrate recipe to conan v2, add gfortran to compilation
  Revert "(conan-io#14221) [config] Use larger resources to build cppfront packages" (conan-io#14953)
  (conan-io#15086) openh264: fix tools legacy
  (conan-io#15085) Make xkeyboard-config v2 compatible
  (conan-io#15089) Raise required_conan_version for xorg/system
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants