Skip to content

libpqxx: add version 6.4.8, support conan v2, remove older versions #14371

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 2, 2022
Merged

libpqxx: add version 6.4.8, support conan v2, remove older versions #14371

merged 3 commits into from
Dec 2, 2022

Conversation

toge
Copy link
Contributor

@toge toge commented Nov 22, 2022

Specify library name and version: libpqxx/*

  • add version 6.4.8 (last C++14 version)
  • remove older versions
  • suppor conan v2

@toge
Copy link
Contributor Author

toge commented Nov 22, 2022

Try to close #14117.

@github-actions github-actions bot mentioned this pull request Nov 22, 2022
Open
@conan-center-bot

This comment has been minimized.

Sign in to view
@github-actions
Copy link
Contributor

Hooks produced the following warnings for commit 753ef63
libpqxx/7.7.3 
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libpqxx.so' links to system library 'm' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libpqxx-7.7.so' links to system library 'm' but it is not in cpp_info.system_libs.
libpqxx/7.3.2 
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libpqxx.so' links to system library 'm' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libpqxx-7.3.so' links to system library 'm' but it is not in cpp_info.system_libs.
libpqxx/7.7.4 
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libpqxx.so' links to system library 'm' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libpqxx-7.7.so' links to system library 'm' but it is not in cpp_info.system_libs.
libpqxx/7.4.2 
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libpqxx-7.4.so' links to system library 'm' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libpqxx.so' links to system library 'm' but it is not in cpp_info.system_libs.
libpqxx/7.6.1 
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libpqxx.so' links to system library 'm' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libpqxx-7.6.so' links to system library 'm' but it is not in cpp_info.system_libs.
libpqxx/7.6.0 
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libpqxx.so' links to system library 'm' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libpqxx-7.6.so' links to system library 'm' but it is not in cpp_info.system_libs.
libpqxx/7.7.2 
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libpqxx.so' links to system library 'm' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libpqxx-7.7.so' links to system library 'm' but it is not in cpp_info.system_libs.
libpqxx/7.7.0 
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libpqxx.so' links to system library 'm' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libpqxx-7.7.so' links to system library 'm' but it is not in cpp_info.system_libs.
libpqxx/7.0.7 
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libpqxx.so' links to system library 'm' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libpqxx-7.0.so' links to system library 'm' but it is not in cpp_info.system_libs.
libpqxx/7.1.2 
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libpqxx.so' links to system library 'm' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libpqxx-7.1.so' links to system library 'm' but it is not in cpp_info.system_libs.
libpqxx/7.5.3 
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libpqxx.so' links to system library 'm' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libpqxx-7.5.so' links to system library 'm' but it is not in cpp_info.system_libs.
libpqxx/7.2.1 
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libpqxx-7.2.so' links to system library 'm' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libpqxx.so' links to system library 'm' but it is not in cpp_info.system_libs.
libpqxx/6.4.8 
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libpqxx.so' links to system library 'm' but it is not in cpp_info.system_libs.

@conan-center-bot

This comment has been minimized.

Sign in to view
uilianries
uilianries previously approved these changes Nov 25, 2022
View reviewed changes
Copy link
Member

@uilianries uilianries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jwillikers
jwillikers suggested changes Dec 1, 2022
View reviewed changes
recipes/libpqxx/all/conanfile.py Outdated
else:
check_min_vs(self, 192)

if is_msvc(self) and self.options.shared and self.settings.compiler.runtime == "MTd":
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

compiler.runtime is specific to Visual Studio. Can you use conan.tools.microsoft.msvc_runtime_flag() which supports both Visual Studio and msvc to check against the MTd flag here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jwillikers
Thank you for your comments!
I fixed it.
Let's see it works well.

@toge toge closed this Dec 2, 2022
@toge toge reopened this Dec 2, 2022
@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline

All green in build 4 (630d4a4b9c2458099884399100000ea6f4a6b2b3):

  • libpqxx/7.7.4@:
    All packages built successfully! (All logs)

  • libpqxx/7.7.3@:
    All packages built successfully! (All logs)

  • libpqxx/7.6.1@:
    All packages built successfully! (All logs)

  • libpqxx/7.7.0@:
    All packages built successfully! (All logs)

  • libpqxx/7.6.0@:
    All packages built successfully! (All logs)

  • libpqxx/7.7.2@:
    All packages built successfully! (All logs)

  • libpqxx/7.3.2@:
    All packages built successfully! (All logs)

  • libpqxx/7.4.2@:
    All packages built successfully! (All logs)

  • libpqxx/7.0.7@:
    All packages built successfully! (All logs)

  • libpqxx/7.1.2@:
    All packages built successfully! (All logs)

  • libpqxx/7.2.1@:
    All packages built successfully! (All logs)

  • libpqxx/7.5.3@:
    All packages built successfully! (All logs)

  • libpqxx/6.4.8@:
    All packages built successfully! (All logs)

@conan-center-bot conan-center-bot merged commit 2456148 into conan-io:master Dec 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prince-chrismc prince-chrismc prince-chrismc approved these changes

@jwillikers jwillikers jwillikers approved these changes

@uilianries uilianries uilianries left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@toge @conan-center-bot @uilianries @prince-chrismc @jwillikers