gdcm: add 3.0.20 #14362
Merged
gdcm: add 3.0.20 #14362
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use system openssl, json-c and libiconv
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
prince-chrismc
approved these changes
Nov 27, 2022
SpaceIm
reviewed
Nov 28, 2022
| @@ -69,8 +81,12 @@ def generate(self): | |||
| tc.variables["GDCM_BUILD_SHARED_LIBS"] = bool(self.options.shared) | |||
| # FIXME: unvendor deps https://github.com/conan-io/conan-center-index/pull/5705#discussion_r647224146 | |||
| tc.variables["GDCM_USE_SYSTEM_EXPAT"] = True | |||
| tc.variables["GDCM_USE_SYSTEM_JSON"] = self.options.with_json | |||
There was a problem hiding this comment.
I don't understand. What happen when with_json option is False? gdcm still uses json-c but bundled one?
There was a problem hiding this comment.
Moreover the json patch could be more robust, upstream doesn't rely on official json-c config filen but on a custom FindJSON.cmake file.
There was a problem hiding this comment.
If I understood correctly, without GDCM_USE_SYSTEM_JSON json functionality just won't work - there is no gdcm internal analogue. Same with openssl. Theoretically some people might want to use it but it's not part of core functionality - I didn't even know that gdcm has it for many years.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use system openssl, json-c, libiconv, libuuid
Specify library name and version: gdcm/all