qwt: many changes & improvements #14249
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I detected other pull requests that are modifying qwt/all recipe: This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prsso don't hesitate to report issues/improvements there. |
This was referenced Nov 17, 2022
- remove pointless options playground, examples & test - use export_conandata_patches - protect deletion of fPIC option with rm_safe - remove jom from build requirements, useless since recipe has moved to CMake - remove cmake & ninja from build requirements: CMake 3.15 is sufficient & ninja not mandatory - use conan.tools.files.copy instead of legacy self.copy - fine-grained cpp-info.requires in package_info() - remove HAVE_QWT definition, it's not needed - define QWT_NO_OPENGL if opengl enabled (not NO_QWT_OPENGL, it was a typo) - QT_PLUGIN_PATH env var is populated only if designer option is enabled. Moreover it's also added to runenv_info for conan v2 generators - test conan v2 generators in test package
Conan v1 pipelineAll green in build 3 (
|
ericriff
reviewed
Nov 25, 2022
| def configure(self): | ||
| if self.options.shared: | ||
| del self.options.fPIC | ||
| def build_requirements(self): |
There was a problem hiding this comment.
Why is qt a build requirement?
There was a problem hiding this comment.
For moc. If moc, uic & rcc were extracted in independent recipes, it would be less painful for downstream recipes.
ericriff
approved these changes
Nov 25, 2022
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.