(#14018) hdf5: allow usage of native built for cross #14019
Conversation
|
|
This comment has been minimized.
This comment has been minimized.
ghost
mentioned this pull request
|
I detected other pull requests that are modifying hdf5/all recipe:
This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prsso don't hesitate to report issues/improvements there. |
recipes/hdf5/all/conanfile.py
Outdated
| def build(self): | ||
| if hasattr(self, "settings_build") and tools.cross_building(self, skip_x64_x86=True): | ||
| # While building it runs some executables like H5detect | ||
| raise ConanInvalidConfiguration("Current recipe doesn't support cross-building (yet)") |
There was a problem hiding this comment.
There is a new method validate_build() since conan 1.51.0. I guess it's the good place to prevent cross-building, while allowing to consume an existing binary in case of cross-build scenario.
Signed-off-by: Pavel Boldin <[email protected]>
pavelb-techspark
force-pushed
the
master
branch
from
d48eab0 to
1a155e2
Compare
Conan v1 pipelineSorry, the build is only launched for Access Request users. You can request access writing in this issue. |
| @@ -97,6 +94,11 @@ def validate(self): | |||
| not self.options["szip"].enable_encoding: | |||
| raise ConanInvalidConfiguration("encoding must be enabled in szip dependency (szip:enable_encoding=True)") | |||
|
|
|||
| def validate_build(self): | |||
| if hasattr(self, "settings_build") and tools.cross_building(self, skip_x64_x86=True): | |||
There was a problem hiding this comment.
| if hasattr(self, "settings_build") and tools.cross_building(self, skip_x64_x86=True): | |
| if hasattr(self, "settings_build") and cross_building(self, skip_x64_x86=True): |
Need to update cross_building, the old form tools.cross_building is deprecated. https://docs.conan.io/en/latest/reference/conanfile/tools/build.html#conan-tools-build-cross-building
Need to add the follow import:
from conan.tools.build import cross_building
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
This pull request has been automatically closed because it has not had recent activity. Thank you for your contributions. |
Specify library name and version: hdf5/all
This patch allows usage of natively-built HDF5 packages for cross-building.