Skip to content

watcher: add recipe #13638

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Oct 25, 2022
Merged

watcher: add recipe #13638

merged 13 commits into from
Oct 25, 2022

Conversation

toge
Copy link
Contributor

@toge toge commented Oct 20, 2022

Specify library name and version: watcher/*


  • I've read the guidelines for contributing.
  • I've followed the PEP8 style guides for Python code in the recipes.
  • I've used the latest Conan client version.
  • I've tried at least one configuration locally with the conan-center hook activated.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

cmake.build()

def test(self):
# don't execute test_package
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You use subprocess.run and pass a timeout: https://docs.python.org/3/library/subprocess.html#subprocess.run

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@uilianries Thanks! I will try.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@uilianries
I have finished.
But watcher released newer version and updated example which uses thread.

I will rewrite test_package.cpp to follow upstream example.

@toge toge marked this pull request as draft October 21, 2022 14:27
@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@toge toge marked this pull request as ready for review October 23, 2022 14:15
@toge toge marked this pull request as draft October 24, 2022 07:54
@toge toge marked this pull request as ready for review October 24, 2022 09:07
@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

"0.3.1":
- patch_file: "patches/0.3.1-fix-include.patch"
patch_description: "add missing include headers for some compilers"
patch_type: "backport"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this is from a commit or PR please add a link but this does not seems like a "backport" ad defined by the docs

Suggested change
patch_type: "backport"
patch_type: "portability"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@prince-chrismc
I agree with you.
I am going to create PR for upstream.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

Copy link
Contributor

@prince-chrismc prince-chrismc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super minor nits otherwise this is perfect

toge and others added 2 commits October 25, 2022 08:27
Co-authored-by: Chris Mc <[email protected]>
Co-authored-by: Chris Mc <[email protected]>
@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@toge toge marked this pull request as draft October 25, 2022 00:19
@toge toge marked this pull request as ready for review October 25, 2022 00:55
@conan-center-bot
Copy link
Collaborator

All green in build 12 (b2e6fbe9b7ab148a3bf851c8fcbee20ab6ec2590):

  • watcher/0.3.1@:
    All packages built successfully! (All logs)

Copy link
Member

@uilianries uilianries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@e-dant
Copy link

e-dant commented Oct 25, 2022

Hi -- author of watcher here.

Thank you to @toge and the reviewers.

@prince-chrismc
Copy link
Contributor

Thank you to @toge and the reviewers.

He's the real hero for making the world a better place. One project at a time 😉

@conan-center-bot conan-center-bot merged commit f6cfa4e into conan-io:master Oct 25, 2022
@prince-chrismc
Copy link
Contributor

{"build":"12","commit":"b2e6fbe9b7ab148a3bf851c8fcbee20ab6ec2590","labels":["FAILED_TAG"],"messages":["Failure in build 12 (b2e6fbe9b7ab148a3bf851c8fcbee20ab6ec2590):"," * watcher/0.3.1@:\n Error running command conan graph info --requires watcher/0.3.1@#4a1f04a59e09dcd25711e2d2701c33af -f json -pr:h /home/conan/w/prod-v2_cci_PR-13638/12/e829eeb0-67a1-4541-aa46-97556ab8c992/profile_linux_11_libstdcpp11_gcc_release_64..txt -pr:b /home/conan/w/prod-v2_cci_PR-13638/12/e829eeb0-67a1-4541-aa46-97556ab8c992/profile_linux_11_libstdcpp11_gcc_release_64..txt:\n \n -------- Input profiles --------\n Profile host:\n [settings]\n arch=x86_64\n build_type=Release\n compiler=gcc\n compiler.libcxx=libstdc++11\n compiler.version=11\n os=Linux\n \n Profile build:\n [settings]\n arch=x86_64\n build_type=Release\n compiler=gcc\n compiler.libcxx=libstdc++11\n compiler.version=11\n os=Linux\n \n \n -------- Computing dependency graph --------\n Graph root\n virtual\n Requirements\n watcher/0.3.1#4a1f04a59e09dcd25711e2d2701c33af - Cache\n \n -------- Computing necessary packages --------\n ERROR: watcher/0.3.1: Error in validate() method, line 43\n \tif self.settings.get_safe(\"compiler.cppstd\"):\n \tConanException: 'self.settings' access in 'validate()' method is forbidden\n ","---","Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability."]}

                        >> Failure in build 12 (`b2e6fbe9b7ab148a3bf851c8fcbee20ab6ec2590`) while exporting recipes:
                        >> Failure in build 12 (`b2e6fbe9b7ab148a3bf851c8fcbee20ab6ec2590`):
  • watcher/0.3.1@:
    Error running command conan graph info --requires watcher/0.3.1@#4a1f04a59e09dcd25711e2d2701c33af -f json -pr:h /home/conan/w/prod-v2_cci_PR-13638/12/e829eeb0-67a1-4541-aa46-97556ab8c992/profile_linux_11_libstdcpp11_gcc_release_64..txt -pr:b /home/conan/w/prod-v2_cci_PR-13638/12/e829eeb0-67a1-4541-aa46-97556ab8c992/profile_linux_11_libstdcpp11_gcc_release_64..txt:
    -------- Input profiles --------
    Profile host:
    [settings]
    arch=x86_64
    build_type=Release
    compiler=gcc
    compiler.libcxx=libstdc++11
    compiler.version=11
    os=Linux
    
    Profile build:
    [settings]
    arch=x86_64
    build_type=Release
    compiler=gcc
    compiler.libcxx=libstdc++11
    compiler.version=11
    os=Linux
    
    
    -------- Computing dependency graph --------
    Graph root
        virtual
    Requirements
        watcher/0.3.1#4a1f04a59e09dcd25711e2d2701c33af - Cache
    
    -------- Computing necessary packages --------
    ERROR: watcher/0.3.1: Error in validate() method, line 43
    	if self.settings.get_safe("compiler.cppstd"):
    	ConanException: 'self.settings' access in 'validate()' method is forbidden
    

Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability.

@prince-chrismc
Copy link
Contributor

Done mind me I am just trying to work on the migration pain points and I dump things here :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants