-
Notifications
You must be signed in to change notification settings - Fork 2k
watcher: add recipe #13638
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
watcher: add recipe #13638
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
cmake.build() | ||
|
||
def test(self): | ||
# don't execute test_package |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You use subprocess.run and pass a timeout: https://docs.python.org/3/library/subprocess.html#subprocess.run
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@uilianries Thanks! I will try.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@uilianries
I have finished.
But watcher released newer version and updated example which uses thread.
I will rewrite test_package.cpp to follow upstream example.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
recipes/watcher/all/conandata.yml
Outdated
"0.3.1": | ||
- patch_file: "patches/0.3.1-fix-include.patch" | ||
patch_description: "add missing include headers for some compilers" | ||
patch_type: "backport" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this is from a commit or PR please add a link but this does not seems like a "backport" ad defined by the docs
patch_type: "backport" | |
patch_type: "portability" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@prince-chrismc
I agree with you.
I am going to create PR for upstream.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Super minor nits otherwise this is perfect
Co-authored-by: Chris Mc <[email protected]>
Co-authored-by: Chris Mc <[email protected]>
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
All green in build 12 (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Hi -- author of watcher here. Thank you to @toge and the reviewers. |
He's the real hero for making the world a better place. One project at a time 😉 |
{"build":"12","commit":"b2e6fbe9b7ab148a3bf851c8fcbee20ab6ec2590","labels":["FAILED_TAG"],"messages":["Failure in build 12 (
Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability. |
Done mind me I am just trying to work on the migration pain points and I dump things here :) |
Specify library name and version: watcher/*