-
Notifications
You must be signed in to change notification settings - Fork 2k
rocksdb: add versions 6.27.3 and 6.29.5 #13593
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rocksdb: add versions 6.27.3 and 6.29.5 #13593
Conversation
This comment has been minimized.
This comment has been minimized.
3a53608
to
122d3b2
Compare
This comment has been minimized.
This comment has been minimized.
"6.29.5": | ||
url: "https://github.com/facebook/rocksdb/archive/v6.29.5.tar.gz" | ||
sha256: "ddbf84791f0980c0bbce3902feb93a2c7006f6f53bfd798926143e31d4d756f0" | ||
"6.27.3": |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jiaoew1991 Do you really need those 2 versions? Please, add only the latest version if you need that. In case not needed, please, remove it. In case someone need an older version, a new PR can be opened.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually we need 6.27.3,the latest released version in 6.x is 6.29.5,so I add it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jiaoew1991 So in that case is fine adding both 👍
This comment has been minimized.
This comment has been minimized.
hi @uilianries,I still not have right to trigger CI,what should I do then? |
122d3b2
to
15d4a3d
Compare
This comment has been minimized.
This comment has been minimized.
15d4a3d
to
0c65702
Compare
All green in build 5 (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Specify library name and version: rocksdb/6.27.3 && rocksdb/6.29.5
I'm one of the main contributors to https://github.com/milvus-io/milvus, we want to try to use Conan as C++ package manager, but we are using rocksdb/6.27.3