[docs] header-only package template #12851
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Uilian Ries <[email protected]>
This comment has been minimized.
This comment has been minimized.
4 tasks
uilianries
commented
Sep 7, 2022
|
Updating docs! |
SSE4
approved these changes
Sep 7, 2022
jgsogo
approved these changes
Sep 7, 2022
ericLemanissier
pushed a commit
to ericLemanissier/cocorepo
that referenced
this pull request
Sep 26, 2022
* Add header-only template Signed-off-by: Uilian Ries <[email protected]> * Missing self Signed-off-by: Uilian Ries <[email protected]>
SpaceIm
reviewed
Oct 20, 2022
Comment on lines
+57
to
+58
| # compiler subsettings are not available when building with self.info.clear() | ||
| if self.info.settings.get_safe("compiler.cppstd"): |
There was a problem hiding this comment.
So it doesn't make sense to test this in validate() since it will never enter into this branch. And for me it looks like all this new validate logic based on self.info in conan v2 is broken.
Or you mean that it's a workaround for conan v1 clients?
There was a problem hiding this comment.
No workaround. Need to update by using self.settings unfortunately. So far, there is no solution: conan-io/docs#2778
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #12678