Skip to content

override sentry default backend and not the backend itself #11154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

AndreyMlashkin
Copy link
Contributor

@AndreyMlashkin AndreyMlashkin commented Jun 13, 2022

Specify library name and version: sentry-native/0.4.17

This is also a good place to share with all of us why you are submitting this PR (specially if it is a new addition to ConanCenter): is it a dependency of other libraries you want to package? Are you the author of the library? Thanks!


  • I've read the guidelines for contributing.
  • I've followed the PEP8 style guides for Python code in the recipes.
  • I've used the latest Conan client version.
  • I've tried at least one configuration locally with the conan-center hook activated.

@AndreyMlashkin
Copy link
Contributor Author

Unfortunatelly this does not work as expected.
Logic in config_options does not override default_options.
@memsharded should I open a linked ticket in conan client?

@conan-center-bot

This comment has been minimized.

@github-actions
Copy link
Contributor

Hooks produced the following warnings for commit eb1b0d6
sentry-native/0.4.17
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library '.\bin\sentry.dll' links to system library 'version' but it is not in cpp_info.system_libs.
sentry-native/0.4.15
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library '.\bin\sentry.dll' links to system library 'version' but it is not in cpp_info.system_libs.
sentry-native/0.4.13
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library '.\bin\sentry.dll' links to system library 'version' but it is not in cpp_info.system_libs.

@AndreyMlashkin
Copy link
Contributor Author

Do someone know, why a warning is showed, even if there is such line in a recipe:

        elif self.settings.os == "Windows":
            self.cpp_info.system_libs = ["shlwapi", "dbghelp"]
            if tools.Version(self.version) >= "0.4.7":
                self.cpp_info.system_libs.append("Version")

@prince-chrismc
Copy link
Contributor

Do someone know, why a warning is showed, even if there is such line in a recipe

@ericLemanissier might be able to help 🤞

prince-chrismc
prince-chrismc previously approved these changes Jun 19, 2022
@ericLemanissier
Copy link
Contributor

Most probably because of the capital V on the lib name, which should be lower case

@conan-center-bot
Copy link
Collaborator

All green in build 2 (39da057c6248373130596195dacd02119a10d01d):

  • sentry-native/0.4.17@:
    All packages built successfully! (All logs)

  • sentry-native/0.4.15@:
    All packages built successfully! (All logs)

  • sentry-native/0.2.6@:
    All packages built successfully! (All logs)

  • sentry-native/0.4.13@:
    All packages built successfully! (All logs)

@AndreyMlashkin
Copy link
Contributor Author

@prince-chrismc @ericLemanissier @uilianries @SSE4, please review

@ericLemanissier
Copy link
Contributor

As you realized. This does not work. What you can do is to add an auto value to this option, and sit is a default. Then in the configure(self) method, if the option value is still auto, you can set the actual backend depending on the settings (directly self.option.backend=... to override the auto value)

@ghost
Copy link

ghost commented Jun 20, 2022

I detected other pull requests that are modifying sentry-native/all recipe:

This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there.

@stale
Copy link

stale bot commented Jul 30, 2022

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale
Copy link

stale bot commented Sep 8, 2022

This pull request has been automatically closed because it has not had recent activity. Thank you for your contributions.

@stale stale bot closed this Sep 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants