Skip to content

GithubActions: build branches + pull requests #8817

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

GithubActions: build branches + pull requests #8817

wants to merge 3 commits into from

Conversation

staabm
Copy link
Contributor

@staabm staabm commented Apr 21, 2020

No description provided.

@staabm staabm mentioned this pull request Apr 21, 2020
Closed
1 task
@staabm staabm changed the title GithubActions: build master branch + pull requests GithubActions: branches + pull requests Apr 21, 2020
@staabm staabm changed the title GithubActions: branches + pull requests GithubActions: build branches + pull requests Apr 21, 2020
@Seldaek
Copy link
Member

Seldaek commented Apr 22, 2020

Thanks, it seems like builds are being cancelled though for no reason so not sure I want to merge this until we can figure it out to avoid spamming on every master build.. Like this here https://github.com/composer/composer/pull/8803/checks?check_run_id=606395680 the tests passed but then it got cancelled?! Any idea what can be done there?

Another problem seems that intl ext is not present for php 7.0 only so it can't pass our tests https://github.com/composer/composer/pull/8803/checks?check_run_id=606395793 - reported as shivammathur/setup-php#215 though because it doesn't seem to be a config issue.

@Seldaek Seldaek added this to the 1.10 milestone Apr 22, 2020
@Seldaek
Copy link
Member

Seldaek commented Apr 22, 2020

Also this should target 1.10 branch please :)

@Seldaek
Copy link
Member

Seldaek commented Apr 22, 2020

OK seems cancellations were maybe just github outage, the rest is fixed so I'll cherry-pick this in 1.10 myself thanks nothing more to do here.

@Seldaek
Copy link
Member

Seldaek commented Apr 22, 2020

ef8c410

@Seldaek Seldaek closed this Apr 22, 2020
@staabm staabm deleted the patch-3 branch April 22, 2020 06:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.10
Development

Successfully merging this pull request may close these issues.
2 participants
@staabm @Seldaek