action: simplify the action logic #44
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Split the Download and Install phase 2. Add an explicit option to select the "ParameterSet" for the toolchain source. 3. Inline the (now) single use functions. There is no need to have the ceremony around the function definition and invocation. 4. Specialise the install rules for the particular type of installer shipped for the Swift toolchain. It is unlikely to go to a MSI based installer. This work prepares the composite action to integrate actions/cache to use the tool cache to amortize the cost of the download of the installer. This becomes more important as the installer size increases.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This work prepares the composite action to integrate actions/cache to use the tool cache to amortize the cost of the download of the installer. This becomes more important as the installer size increases.