-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
BREAKING CHANGE: Fix PocketID for v1.0.0 #4711
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BREAKING CHANGE: Fix PocketID for v1.0.0 #4711
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I get this error when running the install script
|
Whats the point in this PR? Its not an issue Section here |
I ran the install script from this PR hoping it'd work for a fresh pocketid 1.0.0 lxc. Apologies if this is not the right place. |
- remove Caddy from installation (HTTPS is still a requirement) - remove NodeJS and Go dependencies - consolidate frontend & backend service into one - update .env file - install compiled binary instead of compiling from release source - add migration path for versions pre-1.0.0 to pocketid.sh
✍️ Description
Previous versions of PocketID used Caddy to serve the frontend. Now that is no longer required. This PR will remove Caddy. The config has been moved to
/root/Caddyfile.bak
. If you were also using Caddy in the same LXC to generate a TLS cert and serve PocketID behind a subdomain, you will need to reinstall Caddy and fix the Caddyfile to use the updated configuration.Users who configured Caddy on a separate LXC also need to adjust their configurations.
Example Caddy config
🔗 Related PR / Issue
Link: #4710
✅ Prerequisites (X in brackets)
🛠️ Type of Change (X in brackets)
README
,AppName.md
,CONTRIBUTING.md
, or other docs.