Pihole Update + Documentation - since 6.0

[nicedevil007]

✅ Have you read and understood the above guidelines?

yes

📜 What is the name of the script you are using?

Pihole

📂 What was the exact command used to execute the script?

bash -c "$(wget -qLO - https://github.com/community-scripts/ProxmoxVE/raw/main/ct/pihole.sh)"

📝 Provide a clear and concise description of the issue.

Pihole Update isn't working anymore because the pihole command isn't found after installation:

I figured out that the pihole command is located here:

root@pihole:~# find / -name pihole
/usr/local/bin/pihole

Further debugging shows that this path isn't available in the $PATH variable:

root@pihole:~# echo $PATH
/sbin:/bin:/usr/sbin:/usr/bin

I added export PATH="/usr/local/bin:$PATH" to my .bashrc and it was fixed.

An other thing I figured out is that this is not working anymore:

It should be this:

⚙️ What settings are you using?

• Default Settings
• Advanced Settings

🖥️ Which Linux distribution are you using?

Debian 12

🔄 Steps to reproduce the issue.

Install pihole, wait until update is available and run the script inside the container.

❌ Paste the full error output (if available).

____  _ __          __   

/ __ () / ____ / /__
/ // / / __ / __ / / _
/ / / / / / // / / __/
// /// //_//_/

⠋environment: line 32: pihole: command not found
⠙
[ERROR] in line 32: exit code 0: while executing command pihole -up

✔️ Updated Pihole

🖼️ Additional context (optional).

No response

[MickLesk]

You pct enter the LXC to update? Thats an Proxmox Bug. On LXC self it works

[githubaff0]

pihole -a -p
pihole setpassword

I just created new pihole LXC via helper script. I can confirm the command shown on the webpage to set the pihole web password should be changed to pihole setpassword.

root@pihole:~# pihole -a -p
Usage: pihole [options]
Example: 'pihole allow -h'
Add '-h' after specific commands for more information on usage
...
Options:
  setpassword [pwd]   Set the password for the web interface
                        Without optional argument, password is read interactively.
                        When specifying a password directly, enclose it in single quotes.
...

root@pihole:~# pihole setpassword
Enter New Password (Blank for no password): 
Confirm Password: 
  [✓] New password set

Also, it may be good to change the URL shown at the end of the install to https instead of http. If you use the http URL, the pihole admin login page warns 'Insecure network connection' and suggests 'Consider upgrading to HTTPS) (end-to-end encryption)`.

[michelroegl-brunner]

i can not reproduce your path issue, it works out of the box for me.

The json will get changed to the new command,