Accessibility improvements in DICOM classes #905
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, @pieper ! If you think there is no need for further reviews, then please go ahead and integrate it (I don't have the rights for CTK). Then I can bump the CTK hash in Slicer. Thank you! |
lassoan
reviewed
Mar 5, 2020
- Make properties of some of the public functions in DICOM table view - Fix bug where the query table name was retrieved from the table name label, so when customizing the label, the query did not work any more
There were convenience functions for certain queries from the DICOM database, but in order to get information more easily, I added displayedNameForPatient (in addition to the existing nameForPatient) because this field is the human readable name of the patient, and three functions for querying any field: fieldForPatient, fieldForStudy, and fieldForSeries. To be able to query the list of available field (column) names, new functions have been added: patientFieldNames, studyFieldNames, seriesFieldNames
cpinter
force-pushed
the
dicom-table-view-python
branch
from
9d7686d to
78e7072
Compare
|
@lassoan I updated the PR according to your requests. |
|
Thanks for the updates, merged. |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ENH: Add python accessibility for DICOM table view functions
ENH: Allow query of any field from DICOM database