Skip to content

ui: enhanced ListView with improved actions, dynamic content, and better UX #35485

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 9, 2025

Conversation

deanlee
Copy link
Contributor

@deanlee deanlee commented Jun 7, 2025

Major enhancement to the ListView component with improved action system, dynamic content support, better performance optimizations, and enhanced user experience.

Key Changes:
Added new ButtonStyle.LIST_ACTION style for buttons in list views.
New Action System

  • Renamed RightItemItemAction
  • Unified Action Interface: better abstract base class for all elements
  • Added enabled attribute to items.
  • Three Action Types:
    • ToggleAction: Toggle switches with state management
    • ButtonAction: Clickable buttons with customizable text
    • TextAction: Dynamic text display with auto-sizing
  • Fixed various bugs.

Dynamic Content Support

  • Callable Properties: Support for dynamic text, descriptions, and enabled states
  • Auto-Refresh: Dynamic content updates automatically on each render
  • Smart Caching: Performance optimized with cache

@github-actions github-actions bot added the ui label Jun 7, 2025
@deanlee deanlee force-pushed the pyui_improve_listview branch from 70c77a6 to bf7c494 Compare June 7, 2025 00:24
@deanlee deanlee marked this pull request as draft June 7, 2025 01:05
@deanlee deanlee force-pushed the pyui_improve_listview branch 2 times, most recently from b8c6384 to b48406d Compare June 7, 2025 01:16
@deanlee deanlee marked this pull request as ready for review June 7, 2025 01:18
@deanlee deanlee force-pushed the pyui_improve_listview branch 2 times, most recently from 4727714 to ce436f4 Compare June 7, 2025 20:55
@deanlee deanlee force-pushed the pyui_improve_listview branch from ce436f4 to ac7ac1d Compare June 8, 2025 04:20
@deanlee
Copy link
Contributor Author

deanlee commented Jun 9, 2025

@adeebshihadeh Could we merge this? The remaining work in the settings depends on it. If any issues come up later, we can always fix them as we go.

@adeebshihadeh adeebshihadeh merged commit 191d0d4 into commaai:master Jun 9, 2025
16 checks passed
@deanlee deanlee deleted the pyui_improve_listview branch June 9, 2025 02:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants