Add support for LlamaIndex streaming #1769
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexkuzmik
requested changes
Apr 8, 2025
| from llama_index.llms.openai import OpenAI | ||
| from llama_index.core.llms import ChatMessage | ||
|
|
||
| llm = OpenAI(model="gpt-3.5-turbo-0125") |
There was a problem hiding this comment.
It's better not to use the exact version in the test and let the provider just give you the latest. Later they will reduce computation resources for old versions and tests will start failing due to servers overload.
There was a problem hiding this comment.
Done but I doubt that OpenAI will introduce new gpt-3.5 models
| @@ -4,9 +4,13 @@ | |||
| from llama_index.core import Settings | |||
| from llama_index.core.base.llms.types import ChatResponse | |||
| from llama_index.core.callbacks import schema as llama_index_schema | |||
| from llama_index.core.callbacks import ( | |||
There was a problem hiding this comment.
please import modules (I know it was already violated in this file)
There was a problem hiding this comment.
Was it only for llama_index imports or also opik?
| self._opik_client.span(**span_data.__dict__) | ||
|
|
||
| del self._map_event_id_to_span_data[event_id] | ||
| # # Orphaned events where the output was received after end_trace |
There was a problem hiding this comment.
do we need this comment or it can be deleted?
alexkuzmik
approved these changes
Apr 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
Issues
Fix #1743
Testing
Documentation