Skip to content

Fixed an issue in search and replace #61

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 15, 2024

Conversation

duchenean
Copy link
Member

No description provided.

@duchenean duchenean force-pushed the search_replace_do_not_fail_on_None_filename branch from bdbb307 to 03bf94f Compare September 26, 2024 14:48
@duchenean duchenean force-pushed the search_replace_do_not_fail_on_None_filename branch from 03bf94f to 52789e7 Compare September 26, 2024 14:50
@duchenean duchenean changed the title Fixed an issue in search and replace Draft: Fixed an issue in search and replace Sep 26, 2024
@duchenean duchenean changed the title Draft: Fixed an issue in search and replace Fixed an issue in search and replace Sep 26, 2024
@duchenean duchenean changed the title Fixed an issue in search and replace draft: Fixed an issue in search and replace Sep 26, 2024
@duchenean duchenean marked this pull request as draft September 26, 2024 15:18
@duchenean duchenean changed the title draft: Fixed an issue in search and replace Fixed an issue in search and replace Sep 26, 2024
@coveralls
Copy link

coveralls commented Oct 15, 2024

Coverage Status

coverage: 91.924% (+0.04%) from 91.882%
when pulling cd1e6ac on search_replace_do_not_fail_on_None_filename
into 9028631 on master.

@duchenean duchenean marked this pull request as ready for review October 15, 2024 11:48
@duchenean duchenean merged commit 9e89c1a into master Oct 15, 2024
10 checks passed
@duchenean duchenean deleted the search_replace_do_not_fail_on_None_filename branch October 15, 2024 11:49
sgeulette added a commit that referenced this pull request Jun 16, 2025
* Fixed an issue in search and replace (#61)

* Add test about None filename issue in search and replace

* Fixed an issue in search and replace

* Fixed issue in DXDocumentGenerationHelperView.check_permission

* Next version will be 4.0

* Libreoffice docker image from harbor (#63)

Signed-off-by: Alexandre Nuttinck <[email protected]>

* Replaced `six.u()` by safe_unicode() to handle unicode strings

* Added plone 6.1 gha

* Changed imio.helpers branch to plone61

* Removed plone 6.1 from test coverage step (keeping plone 6.1)

* Changed python version from 3.13 to 3.12

* Changed python version from 3.12 to 3.13

* Fixed tests for plone 6

---------

Signed-off-by: Alexandre Nuttinck <[email protected]>
Co-authored-by: Antoine Duchêne <[email protected]>
Co-authored-by: Gauthier Bastien <[email protected]>
Co-authored-by: Alexandre Nuttinck <[email protected]>
Co-authored-by: Stephan Geulette <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants