Skip to content

Add Server, Client, and Models Package #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
Apr 10, 2020
Merged

Conversation

patrick-ogrady
Copy link
Contributor

Motivation

To implement a Rosetta server, it was necessary to setup your own codegen toolchain and keep it working across interface updates. This was a drain on engineering resources for anyone working on a server.

Secondly, there were no examples demonstrating how to use the different packages.

Solution

Create a server package that makes it easy to write a Rosetta server, break apart the Rosetta models into a separate package for anyone looking to build their own server, and add a ton of examples.

@patrick-ogrady patrick-ogrady requested review from brockmiller, etscrivner and a team April 10, 2020 17:27
@patrick-ogrady patrick-ogrady changed the title Add support for Server SDK Add Server, Client, and Models Package Apr 10, 2020
@patrick-ogrady patrick-ogrady force-pushed the patrick/server-sdk branch 2 times, most recently from 2e375ce to bde0602 Compare April 10, 2020 17:56
@coveralls
Copy link

Pull Request Test Coverage Report for Build 384

  • 113 of 122 (92.62%) changed or added relevant lines in 5 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+3.9%) to 82.889%

Changes Missing Coverage Covered Lines Changed/Added Lines %
asserter/request.go 71 73 97.26%
asserter/block.go 25 28 89.29%
asserter/network.go 12 16 75.0%
Totals Coverage Status
Change from base Build 158: 3.9%
Covered Lines: 373
Relevant Lines: 450

💛 - Coveralls

Copy link

@etscrivner etscrivner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Big improvements here 👍

@patrick-ogrady patrick-ogrady merged commit 48078aa into master Apr 10, 2020
@patrick-ogrady patrick-ogrady deleted the patrick/server-sdk branch April 10, 2020 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants