-
Notifications
You must be signed in to change notification settings - Fork 137
Add Server, Client, and Models Package #7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2e375ce
to
bde0602
Compare
bde0602
to
603bafe
Compare
7c4249b
to
b7920d0
Compare
b7920d0
to
5f9ab5b
Compare
Pull Request Test Coverage Report for Build 384
💛 - Coveralls |
etscrivner
approved these changes
Apr 10, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Big improvements here 👍
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
To implement a Rosetta server, it was necessary to setup your own codegen toolchain and keep it working across interface updates. This was a drain on engineering resources for anyone working on a server.
Secondly, there were no examples demonstrating how to use the different packages.
Solution
Create a server package that makes it easy to write a Rosetta server, break apart the Rosetta models into a separate package for anyone looking to build their own server, and add a ton of examples.