Related ops checks #355
Merged
Related ops checks #355
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
asserter/asserter.go
Outdated
| Payment *ValidationOperation `json:"payment"` | ||
| Fee *ValidationOperation `json:"fee"` | ||
| Enabled bool `json:"enabled"` | ||
| RelatedOps bool `json:"related_ops"` |
There was a problem hiding this comment.
Should we rename it something like related_op_present or related_op_exists? or something which sounds more like a boolean? just RelatedOps is not clear of what that param is.
|
You might want to run |
shrimalmadhur
approved these changes
Nov 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes # .
Motivation
Currently we don't flag an asset if it doesn't have related operations implemented. Implementing related operations is optional, we only need it to be implemented if we have multiple outputs or we don't distinguish between sends/receives. In that case, ChainIO will break because it uses related operations to enforce a DAG structure on the operations.
Solution
Make related operations support configurable. If a related_operations_enabled is set to true in validator file, then throw error if related operations key doesn't exist. Otherwise, just print warning.
Open questions