Skip to content

Add historical balance lookup #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 18, 2020

Conversation

patrick-ogrady
Copy link
Contributor

@patrick-ogrady patrick-ogrady commented Apr 17, 2020

Motivation

  • Calls to fetch an account balance in the fetcher did not allow for providing a PartialBlockIdentifier for a historical balance query
  • Calls to fetch an Account balance in the fetcher did not return account metadata

Solution

Fixed both issues. Also added an assertion to ensure that historical balance query responses contain a BlockIdentifier related to the query PartialBlockIdentifier.

Miscellaneous

Once this is merged, it will be possible to perform rosetta-validator reconciliation while syncing.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 569

  • 22 of 22 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.4%) to 89.855%

Totals Coverage Status
Change from base Build 562: 0.4%
Covered Lines: 434
Relevant Lines: 483

💛 - Coveralls

@patrick-ogrady patrick-ogrady changed the title [WIP] Add historical balance lookup Add historical balance lookup Apr 18, 2020
@patrick-ogrady patrick-ogrady changed the title Add historical balance lookup Fix historical balance lookup Apr 18, 2020
@patrick-ogrady patrick-ogrady changed the title Fix historical balance lookup Add historical balance lookup Apr 18, 2020
@patrick-ogrady patrick-ogrady merged commit 5bc784a into master Apr 18, 2020
@patrick-ogrady patrick-ogrady deleted the patrick/historical-balance-lookup branch April 18, 2020 01:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants