Skip to content

1.3.1 Release #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Apr 15, 2020
Merged

1.3.1 Release #11

merged 7 commits into from
Apr 15, 2020

Conversation

patrick-ogrady
Copy link
Contributor

@patrick-ogrady patrick-ogrady commented Apr 15, 2020 •
edited
Loading

  • Run codegen using the 1.3.1 Rosetta specification
  • Cleanup fetcher construction and fetcher retry methods
  • Remove log.Fatal calls from server package (if there is an error encoding a response just use http.error)

@coveralls
Copy link

Pull Request Test Coverage Report for Build 498

  • 52 of 64 (81.25%) changed or added relevant lines in 5 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+3.7%) to 86.788%
Changes Missing Coverage Covered Lines Changed/Added Lines %
asserter/network.go 28 40 70.0%
Files with Coverage Reduction New Missed Lines %
asserter/network.go 2 72.92%
Totals Coverage Status
Change from base Build 459: 3.7%
Covered Lines: 381
Relevant Lines: 439
💛 - Coveralls

@heimdall-asguard
Copy link

Review Error for niallo @ 2020-04-15 06:19:19 UTC
User failed mfa authentication, public email is not set on your github profile. see go/mfa-help

@heimdall-asguard
Copy link

Review Error for niallo @ 2020-04-15 06:20:39 UTC
User failed mfa authentication, public email is not set on your github profile. see go/mfa-help

@patrick-ogrady patrick-ogrady merged commit 2ce25c6 into master Apr 15, 2020
@patrick-ogrady patrick-ogrady deleted the patrick/1.3.1-release branch April 15, 2020 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@niallo niallo niallo approved these changes

@annieke annieke annieke approved these changes

@brockmiller brockmiller Awaiting requested review from brockmiller

@etscrivner etscrivner Awaiting requested review from etscrivner

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@patrick-ogrady @coveralls @heimdall-asguard @niallo @annieke