Skip to content
This repository was archived by the owner on Jan 20, 2020. It is now read-only.

Add stablecoin conversion #347

Merged
merged 5 commits into from
Nov 2, 2018
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -413,11 +413,22 @@ authedClient.marginTransfer(params, callback);

```js
const params = {
repay_only: false,
repay_only: false
};
authedClient.closePosition(params, callback);
```

* [`convert`](https://docs.gdax.com/#create-conversion)

```js
const params = {
from: 'USD',
to: 'USDC',
amount: '100'
};
authedClient.convert(params, callback);
```

* [`deposit`, `withdraw`](https://docs.gdax.com/#deposits)

```js
Expand Down
3 changes: 3 additions & 0 deletions index.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -261,6 +261,9 @@ declare module 'gdax' {
closePosition(params: any, callback: callback<any>): void;
closePosition(params: any): Promise<any>;

convert(params: any, callback: callback<any>): void;
convert(params: any): Promise<any>;

deposit(params: any, callback: callback<any>): void;
deposit(params: any): Promise<any>;

Expand Down
5 changes: 5 additions & 0 deletions lib/clients/authenticated.js
Original file line number Diff line number Diff line change
Expand Up @@ -243,6 +243,11 @@ class AuthenticatedClient extends PublicClient {
this._requireParams(params, ['repay_only']);
return this.post(['position/close'], { body: params }, callback);
}

convert(params, callback) {
this._requireParams(params, ['from', 'to', 'amount']);
return this.post(['conversions'], { body: params }, callback);
}

deposit(params, callback) {
this._requireParams(params, ['amount', 'currency', 'coinbase_account_id']);
Expand Down
38 changes: 34 additions & 4 deletions tests/authenticated.spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -709,6 +709,36 @@ suite('AuthenticatedClient', () => {
.catch(err => assert.ifError(err) || assert.fail());
});

test('.convert()', done => {
const transfer = {
from: 'USD',
to: 'USDC',
amount: '100',
};

const expectedTransfer = transfer;

nock(EXCHANGE_API_URL)
.post('/conversions', expectedTransfer)
.times(2)
.reply(200, {});

let cbtest = new Promise((resolve, reject) => {
authClient.convert(transfer, err => {
if (err) {
reject(err);
}
resolve();
});
});

let promisetest = authClient.convert(transfer);

Promise.all([cbtest, promisetest])
.then(() => done())
.catch(err => assert.ifError(err) || assert.fail());
});

test('.deposit()', done => {
const transfer = {
amount: 10480,
Expand Down Expand Up @@ -736,7 +766,7 @@ suite('AuthenticatedClient', () => {

Promise.all([cbtest, promisetest])
.then(() => done())
.catch(err => assert.ifError(err) || assert.fail);
.catch(err => assert.ifError(err) || assert.fail());
});

test('.depositPayment()', done => {
Expand Down Expand Up @@ -766,7 +796,7 @@ suite('AuthenticatedClient', () => {

Promise.all([cbtest, promisetest])
.then(() => done())
.catch(err => assert.ifError(err) || assert.fail);
.catch(err => assert.ifError(err) || assert.fail());
});

test('.depositCrypto()', done => {
Expand Down Expand Up @@ -823,7 +853,7 @@ suite('AuthenticatedClient', () => {

Promise.all([cbtest, promisetest])
.then(() => done())
.catch(err => assert.ifError(err) || assert.fail);
.catch(err => assert.ifError(err) || assert.fail());
});

test('.withdraw()', done => {
Expand Down Expand Up @@ -883,7 +913,7 @@ suite('AuthenticatedClient', () => {

Promise.all([cbtest, promisetest])
.then(() => done())
.catch(err => assert.ifError(err) || assert.fail);
.catch(err => assert.ifError(err) || assert.fail());
});

test('.createReport()', done => {
Expand Down