Skip to content

Refactor(react-components): Refactor the Reveal domain objects and commands (Part 1) #5250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 11 commits into
base: np/achitecture-work
Choose a base branch
from

Conversation

nilscognite
Copy link
Contributor

@nilscognite nilscognite commented Aug 1, 2025

Type of change

Refactor

Jira ticket 📘

https://cognitedata.atlassian.net/browse/

Description 📝

This is part 1 in using DomainObjects and signals in the Reveal settings command for PointCloud, Cad and Image360Collection.

Work on PointCloudDomainObject

Removed PointCloudStyle. This was not needed since it didn't fit into Reveal data model. Instead added signal base visual settings in PointCloudDomainObject.

The PointCloudMock has been updated to prepare for testing. The testing itself will be added in Part 2.

Work on CadDomainObject:

Removed CadCloudStyle. Not needed

Work on Image360CollectionDomainObject:

Removed Image360CollectionRenderStyle . Not needed

How has this been tested? 🔍

Test instructions ℹ️

Checklist ☑️

  • I am happy with this implementation.
  • I have performed a self-review of my own code.
  • I have added unit and visuals tests to prove that my feature works to the best of my ability.
  • I have added documentation to new and changed elements; both public and internally shared ones
  • I have refactored the code for testability, readability and extendibility to the best of my ability.
  • I have listed the JIRA tasks covering remaining work or tech debt related to this PR in the description.

@nilscognite nilscognite requested a review from a team as a code owner August 1, 2025 05:47
@nilscognite nilscognite changed the base branch from master to np/achitecture-work August 1, 2025 05:48
Copy link

codecov bot commented Aug 1, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 63.87%. Comparing base (f975ea3) to head (e4887e5).

Additional details and impacted files
@@                   Coverage Diff                   @@
##           np/achitecture-work    #5250      +/-   ##
=======================================================
+ Coverage                63.84%   63.87%   +0.02%     
=======================================================
  Files                     1171     1168       -3     
  Lines                    82517    82460      -57     
  Branches                  7409     7403       -6     
=======================================================
- Hits                     52686    52672      -14     
+ Misses                   29690    29647      -43     
  Partials                   141      141              
Files with missing lines Coverage Δ
...chitecture/base/renderTarget/RevealRenderTarget.ts 61.70% <ø> (ø)
...age360Collection/Image360CollectionDomainObject.ts 100.00% <100.00%> (ø)
.../Image360Collection/Image360CollectionThreeView.ts 68.57% <100.00%> (+11.12%) ⬆️
...rchitecture/concrete/reveal/cad/CadDomainObject.ts 100.00% <100.00%> (ø)
...c/architecture/concrete/reveal/cad/CadThreeView.ts 80.00% <100.00%> (+15.71%) ⬆️
...ncrete/reveal/pointCloud/PointCloudDomainObject.ts 100.00% <100.00%> (ø)
.../concrete/reveal/pointCloud/PointCloudThreeView.ts 80.00% <100.00%> (+15.71%) ⬆️

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@nilscognite nilscognite changed the title Refactor(react-components): Refactor the reveal domain objects Refactor(react-components): Refactor the Reveal domain objects Aug 1, 2025
@nilscognite nilscognite changed the title Refactor(react-components): Refactor the Reveal domain objects Refactor(react-components): Refactor the Reveal domain objects and commands (Part 1) Aug 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant