-
Notifications
You must be signed in to change notification settings - Fork 22
Refactor(react-components): Refactor the Reveal domain objects and commands (Part 1) #5250
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
nilscognite
wants to merge
11
commits into
np/achitecture-work
Choose a base branch
from
no/reveal-object-refacoring
base: np/achitecture-work
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## np/achitecture-work #5250 +/- ##
=======================================================
+ Coverage 63.84% 63.87% +0.02%
=======================================================
Files 1171 1168 -3
Lines 82517 82460 -57
Branches 7409 7403 -6
=======================================================
- Hits 52686 52672 -14
+ Misses 29690 29647 -43
Partials 141 141
🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Jira ticket 📘
https://cognitedata.atlassian.net/browse/
Description 📝
This is part 1 in using
DomainObjects
and signals in the Reveal settings command for PointCloud, Cad and Image360Collection.Work on PointCloudDomainObject
Removed
PointCloudStyle
. This was not needed since it didn't fit into Reveal data model. Instead added signal base visual settings inPointCloudDomainObject
.The
PointCloudMock
has been updated to prepare for testing. The testing itself will be added in Part 2.Work on CadDomainObject:
Removed
CadCloudStyle
. Not neededWork on Image360CollectionDomainObject:
Removed
Image360CollectionRenderStyle
. Not neededHow has this been tested? 🔍
Test instructions ℹ️
Checklist ☑️