Skip to content

feat(react-component): Set names to the Reveal domain objects #5248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

nilscognite
Copy link
Contributor

@nilscognite nilscognite commented Jul 31, 2025

Type of change

Feat

Jira ticket 📘

Description 📝

When loading a Reveal domain object, it also set the name of it. This will be used the the tree control or other places.

Also changed getByRevealModel to use getDescendantsByType instead of getChildrenByType, since this is more general.

How has this been tested? 🔍

By unit test. In production the names are not used yet.

Checklist ☑️

  • I am happy with this implementation.
  • I have performed a self-review of my own code.
  • I have added unit and visuals tests to prove that my feature works to the best of my ability.
  • I have added documentation to new and changed elements; both public and internally shared ones
  • I have refactored the code for testability, readability and extendibility to the best of my ability.
  • I have listed the JIRA tasks covering remaining work or tech debt related to this PR in the description.

@nilscognite nilscognite requested a review from a team as a code owner July 31, 2025 11:26
@nilscognite nilscognite changed the title feat(react-component): Add names to the Reveal domain objects feat(react-component): Set names to the Reveal domain objects Jul 31, 2025
Copy link

codecov bot commented Jul 31, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 63.87%. Comparing base (2637647) to head (1ab61c7).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5248      +/-   ##
==========================================
+ Coverage   63.86%   63.87%   +0.01%     
==========================================
  Files        1171     1171              
  Lines       82503    82524      +21     
  Branches     7407     7403       -4     
==========================================
+ Hits        52693    52716      +23     
+ Misses      29669    29667       -2     
  Partials      141      141              
Files with missing lines Coverage Δ
...age360Collection/Image360CollectionDomainObject.ts 100.00% <100.00%> (ø)
.../architecture/concrete/reveal/RevealModelsUtils.ts 93.89% <100.00%> (+14.61%) ⬆️

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant