Skip to content

Try to fix BND3D-5695 by adding some debugging code #5242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

nilscognite
Copy link
Contributor

Type of change

Feat
Bug
Test
Docs
Style
Refactor
Chore

Jira ticket 📘

https://cognitedata.atlassian.net/browse/

Description 📝

How has this been tested? 🔍

Test instructions ℹ️

Checklist ☑️

  • I am happy with this implementation.
  • I have performed a self-review of my own code.
  • I have added unit and visuals tests to prove that my feature works to the best of my ability.
  • I have added documentation to new and changed elements; both public and internally shared ones
  • I have refactored the code for testability, readability and extendibility to the best of my ability.
  • I have listed the JIRA tasks covering remaining work or tech debt related to this PR in the description.

@nilscognite nilscognite requested a review from a team as a code owner July 25, 2025 12:56
@nilscognite nilscognite marked this pull request as draft July 25, 2025 12:56
Copy link

codecov bot commented Jul 25, 2025

Codecov Report

❌ Patch coverage is 85.71429% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 63.55%. Comparing base (2637647) to head (0ce8f6f).

Files with missing lines Patch % Lines
viewer/packages/api/src/public/RevealManager.ts 0.00% 1 Missing ⚠️
...ckages/api/src/public/migration/Cognite3DViewer.ts 0.00% 1 Missing ⚠️
.../cad-geometry-loaders/src/CadModelUpdateHandler.ts 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5242      +/-   ##
==========================================
- Coverage   63.86%   63.55%   -0.32%     
==========================================
  Files        1171     1163       -8     
  Lines       82503    82161     -342     
  Branches     7407     7299     -108     
==========================================
- Hits        52693    52214     -479     
- Misses      29669    29806     +137     
  Partials      141      141              
Files with missing lines Coverage Δ
...er/packages/cad-geometry-loaders/src/CadManager.ts 68.95% <100.00%> (+1.04%) ⬆️
...packages/utilities/src/cache/MemoryRequestCache.ts 95.55% <100.00%> (+0.24%) ⬆️
viewer/packages/api/src/public/RevealManager.ts 88.88% <0.00%> (-0.29%) ⬇️
...ckages/api/src/public/migration/Cognite3DViewer.ts 68.37% <0.00%> (-0.04%) ⬇️
.../cad-geometry-loaders/src/CadModelUpdateHandler.ts 83.66% <50.00%> (-0.28%) ⬇️

... and 39 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant