chore: add react hooks rules eslint plugin #5209
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5209 +/- ##
==========================================
+ Coverage 60.64% 60.71% +0.07%
==========================================
Files 1145 1145
Lines 81747 81613 -134
Branches 7014 7006 -8
==========================================
- Hits 49575 49553 -22
+ Misses 31989 31845 -144
- Partials 183 215 +32
🚀 New features to boost your workflow:
|
nilscognite
previously approved these changes
Jul 2, 2025
haakonflatval-cognite
requested changes
Jul 2, 2025
| @@ -87,7 +87,7 @@ const DropdownElement = ({ | |||
| </Button> | |||
| </CogsTooltip> | |||
| )}> | |||
| {command.children.map((child) => createMenuItem(child, setOpen))} | |||
| {command.children.map((child) => CreateMenuItem(child, setOpen))} | |||
There was a problem hiding this comment.
This doesn't seem righ to me - CreateMenuItem contains a hook call, and when we call the component like a function like this, the hook will be counted as part of the parent components' hook. That means that if the number or order of commands change for some reason, the number of hook calls in this component will change, and React may explode
There was a problem hiding this comment.
I see that this may be the case in other components in this PR as well
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description 📝
Enable lint plugin for react hooks rules