Skip to content

chore: preserve modules and outdir #5191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

christjt
Copy link
Contributor

@christjt christjt commented Jun 24, 2025

Type of change

Chore

Description 📝

Preserve modules in the lib output. This makes it easier to reason about the output of the lib and apps will bundle anyway, so likely no reason for us to do it.

Also do not clear the out dir, as this will break the links (using the file: protocol).

Process for linking to fusion:
image

Search for all package.json files including the regex (remember to enable if in VSCode) "@cognite/reveal-react-components":.*, and replace with the absolute path to the react components lib. For me that is: "@cognite/reveal-react-components": "file:///Users/ChristopherTannum/reveal/react-components", this may or may not be different depending on OS etc. Then click replace all.

When building react components, then output in node_modules in fusion should be automatically updated:

Recording.2025-06-24.110752.mp4

Test instructions ℹ️

Follow the procedure setup in the description in fusion, and validate that updates happen without needing to re-serve subapp.

@christjt christjt requested a review from a team as a code owner June 24, 2025 09:08
Copy link

codecov bot commented Jun 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.23%. Comparing base (5042718) to head (6414b8d).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5191   +/-   ##
=======================================
  Coverage   60.23%   60.23%           
=======================================
  Files        1145     1145           
  Lines       81726    81726           
  Branches     6908     6910    +2     
=======================================
+ Hits        49228    49230    +2     
+ Misses      32315    32280   -35     
- Partials      183      216   +33     

see 29 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@danpriori danpriori left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two questions. Probably the sourcemap is not working.
The rest looks good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants