-
Notifications
You must be signed in to change notification settings - Fork 22
chore: preserve modules and outdir #5191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
christjt
wants to merge
4
commits into
master
Choose a base branch
from
christjt/preserve-lib-output
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5191 +/- ##
=======================================
Coverage 60.23% 60.23%
=======================================
Files 1145 1145
Lines 81726 81726
Branches 6908 6910 +2
=======================================
+ Hits 49228 49230 +2
+ Misses 32315 32280 -35
- Partials 183 216 +33 🚀 New features to boost your workflow:
|
danpriori
requested changes
Jun 24, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two questions. Probably the sourcemap is not working.
The rest looks good.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description 📝
Preserve modules in the lib output. This makes it easier to reason about the output of the lib and apps will bundle anyway, so likely no reason for us to do it.
Also do not clear the out dir, as this will break the links (using the
file:
protocol).Process for linking to fusion:

Search for all package.json files including the regex (remember to enable if in VSCode)
"@cognite/reveal-react-components":.*,
and replace with the absolute path to the react components lib. For me that is:"@cognite/reveal-react-components": "file:///Users/ChristopherTannum/reveal/react-components",
this may or may not be different depending on OS etc. Then click replace all.When building react components, then output in node_modules in fusion should be automatically updated:
Recording.2025-06-24.110752.mp4
Test instructions ℹ️
Follow the procedure setup in the description in fusion, and validate that updates happen without needing to re-serve subapp.