Skip to content

[TBE-108] Rotate Twilio Credentials #6004

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 12, 2025

Conversation

arinchoi03
Copy link
Contributor

@arinchoi03 arinchoi03 commented Jun 9, 2025

Link to pivotal/JIRA issue

Is PM acceptance required? (delete one)

  • Yes - don't merge until JIRA issue is accepted!

Reminder: merge main into this branch and get green tests before merging to main

What was done?

How to test?

  • For Dev:
    • I did VISUAL="vi" bin/rails credentials:edit --environment=<env> but whatever you want to do to view the credentials. Make sure that the token matches the secondary token on twilio
  • Describe the testing approach taken to verify the changes, including:
    • Ensure that twilio messaging works on demo/staging
    • Monitor Twilio messaging post production deploy

Screenshots (for visual changes)

  • Before
  • After

Copy link

github-actions bot commented Jun 9, 2025

Heroku app: https://gyr-review-app-6004-0cb9aca18bda.herokuapp.com/
View logs: heroku logs --app gyr-review-app-6004 (optionally add --tail)

@arinchoi03 arinchoi03 marked this pull request as ready for review June 9, 2025 22:45
@powersurge360
Copy link
Contributor

There's also bin/gyr credentials_diff --base main to try locally. I won't screenshot it but it exists!

@powersurge360
Copy link
Contributor

If you can show me how to compare against the twilio interface tomorrow I'll approve. Basically approved now.

@arinchoi03
Copy link
Contributor Author

There's also bin/gyr credentials_diff --base main to try locally. I won't screenshot it but it exists!

Ooh I forgot about this command. Ty!

Copy link
Contributor

@powersurge360 powersurge360 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Verified w/ credentials_diff and checking out the tokens on the console.

@arinchoi03 arinchoi03 merged commit 1918ccc into main Jun 12, 2025
8 checks passed
@arinchoi03 arinchoi03 deleted the TBE-108-rotate-runbook-twilio-api-credentials branch June 12, 2025 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants