Skip to content

Update NJ Flat EITC rate to TY24 amount #5995

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 12, 2025
Merged

Update NJ Flat EITC rate to TY24 amount #5995

merged 2 commits into from
Jun 12, 2025

Conversation

jachan
Copy link
Contributor

@jachan jachan commented May 28, 2025 •
edited
Loading

Link to pivotal/JIRA issue

Is PM acceptance required? (delete one)

  • Yes - don't merge until JIRA issue is accepted!

Reminder: merge main into this branch and get green tests before merging to main

What was done?

How to test?

  • On Heroku, use the Childless EITC persona
  • answer "no" to the question about being claimed as someone else's qualifying child for EITC
  • verify that EITC credit is 253$

Screenshots (for visual changes)

  • Before
image image
  • After
image image image

@github-actions GitHub Actions
Copy link

Heroku app: https://gyr-review-app-5995-d32b0762f826.herokuapp.com/
View logs: heroku logs --app gyr-review-app-5995 (optionally add --tail)

@jachan jachan marked this pull request as ready for review May 28, 2025 20:11
@jachan jachan requested review from mmazanec22 and aloverso May 28, 2025 20:13
@jachan jachan assigned jachan, aloverso and mmazanec22 and unassigned jachan May 28, 2025
mmazanec22
mmazanec22 approved these changes May 28, 2025
View reviewed changes
Copy link
Contributor

@mmazanec22 mmazanec22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops! Thanks for fixing

aloverso
aloverso approved these changes May 29, 2025
View reviewed changes
Copy link
Contributor

@aloverso aloverso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

straightforward!

@jachan jachan self-assigned this May 29, 2025
@jachan jachan merged commit 51c9c64 into main Jun 12, 2025
8 checks passed
@jachan jachan deleted the nj-247-update-eitc-rate branch June 12, 2025 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aloverso aloverso aloverso approved these changes

@mmazanec22 mmazanec22 mmazanec22 approved these changes

@mpidcock mpidcock mpidcock approved these changes

Assignees

@jachan jachan

@aloverso aloverso

@mmazanec22 mmazanec22

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jachan @aloverso @mmazanec22 @mpidcock